From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 317F621D10
	for <tarantool-patches@freelists.org>; Wed, 20 Jun 2018 04:10:47 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id rQDn_Tnw-vKu for <tarantool-patches@freelists.org>;
	Wed, 20 Jun 2018 04:10:47 -0400 (EDT)
Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9E1AC21CFF
	for <tarantool-patches@freelists.org>; Wed, 20 Jun 2018 04:10:46 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v3 10/10] sql: VDBE tests for
 trigger existence
References: <cover.1528997527.git.kshcherbatov@tarantool.org>
 <2dc4c354dc72123c3447831a6ac48038eaf95f48.1528997527.git.kshcherbatov@tarantool.org>
 <05ff2cb5-d224-7b04-5aa8-d7d57b7c0031@tarantool.org>
 <ad1f65f3-28aa-def0-e539-32c4f35497de@tarantool.org>
 <04bda6c6-247c-0ad4-b78d-701d1d34c974@tarantool.org>
 <79bd10d4-579b-92b3-e1ed-755d33febb8b@tarantool.org>
 <4ed9ea53-a3b1-a633-9174-f7db97f3e40c@tarantool.org>
 <d8366d57-2cd8-89fc-6f24-a5664a483ec7@tarantool.org>
 <ec850cdd-d19e-8e2e-53b6-32a2c82441da@tarantool.org>
 <912df24e-f75d-06a7-7c25-8ed0727c811d@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <1533af93-4d67-0358-e0d5-d13d9218b4cd@tarantool.org>
Date: Wed, 20 Jun 2018 11:10:36 +0300
MIME-Version: 1.0
In-Reply-To: <912df24e-f75d-06a7-7c25-8ed0727c811d@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>, tarantool-patches@freelists.org

Hello. Thanks for the fixes!

Now the same comment as a pair reviews before:
parameter name mismatch in header and source.

On 20/06/2018 09:38, Kirill Shcherbatov wrote:
>> As I told you verbally, here you can use directly diag_set since
>> you know the concrete error code and parameters.
>>
>> So please, apply this diff:
>>
>> @@ -3003,10 +3003,8 @@ case OP_CheckViewReferences: {
>>    	struct space *space = space_by_id(space_id);
>>    	assert(space != NULL);
>>    	if (space->def->view_ref_count > 0) {
>> -		box_error_set(__FILE__, __LINE__, ER_DROP_SPACE,
>> -			      tnt_errcode_desc(ER_DROP_SPACE),
>> -			      space->def->name,
>> -			      "other views depend on this space");
>> +		diag_set(ClientError, ER_DROP_SPACE, space->def->name,
>> +			 "other views depend on this space");
>>    		rc = SQL_TARANTOOL_ERROR;
>>    		goto abort_due_to_error;
>>    	}
>>
>>>    		rc = SQL_TARANTOOL_ERROR;
>>>    		goto abort_due_to_error;
>>>    	}
>>
> Thank you for review. Applied.
>