From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 85C466BD28; Tue, 13 Apr 2021 02:37:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 85C466BD28 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618270641; bh=VuU5/U2XeMFt9NsLn+OsceptgI3g5txFl5wN+HZDHCU=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=GLCEsp1DzqRy3U2JDd4mXyqVHLGHzJjbtotcShhEe3O8wWHhbVwu3D21rSkWC9aeZ q2CkQThpGM97ebjagFX5ZGA1Fa9MzzpXdY1ZYEiaMYk+iVoRCH5n+tnVnZZzxVC3Qr JPWS4xaO5Xjh8lrSbQv3jakHJ3/gbMJ34lnW/TJI= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id ACA246BD28 for ; Tue, 13 Apr 2021 02:37:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ACA246BD28 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lW67B-0005Cp-Un; Tue, 13 Apr 2021 02:37:10 +0300 To: imeevma@tarantool.org, tsafin@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: Message-ID: <152c58c6-460b-64ad-bbd9-2c9deea2c92d@tarantool.org> Date: Tue, 13 Apr 2021 01:37:08 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E74807BAE725B9AE625DE765B0E193B5B7687182A05F538085040EAA8DCCA6741C76E2EC83885F9D145F82900965B8BD87872EEE2EA85675214E8 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7EC0B1A4921CAE631EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637600371203F35D8CB8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B290A29E39E863E29DF8EDB81DBEAA27EA3C743118508A179DD2E47CDBA5A96583C09775C1D3CA48CF17B107DEF921CE79117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE709B92020B71E24959FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA73A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735D2D576BCF940C736C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5B2AC455C3A8E6373F2647899478F647B595D316E73BFC814D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34829444FF2D8CB89BD05FE3124D6527D861518351F1C1762AEF9AB2084FE6E72CC2852A7E082FB41F1D7E09C32AA3244CA7E2D08558E7838DF78106EED263CBCC4DBEAD0ED6C55A80FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojq8JA+pXcDunGCAkx2p93LQ== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638229DFFC87B867EB7376946A01AC65BB6563841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v5 35/52] sql: introduce mem_set_frame() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Good job on the patch! > diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c > index c21a6576f..7f1e0bcbe 100644 > --- a/src/box/sql/vdbe.c > +++ b/src/box/sql/vdbe.c > @@ -4163,8 +4163,7 @@ case OP_Program: { /* jump */ > goto no_mem; > } > mem_destroy(pRt); You can remove this destroy call. > - pRt->flags = MEM_Frame; > - pRt->u.pFrame = pFrame; > + mem_set_frame(pRt, pFrame); > > pFrame->v = p; > pFrame->nChildMem = nMem; >