From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 67CB421AB7 for ; Thu, 26 Apr 2018 07:47:20 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YMYGR7czq54U for ; Thu, 26 Apr 2018 07:47:20 -0400 (EDT) Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B34F921AB0 for ; Thu, 26 Apr 2018 07:47:19 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v3 0/4] sql: Removed Column fields to server with region allocations References: From: Vladislav Shpilevoy Message-ID: <1514a0b3-77bd-d971-af63-ea13748fa493@tarantool.org> Date: Thu, 26 Apr 2018 14:47:15 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Kirill Shcherbatov , tarantool-patches@freelists.org Hello. Thanks for contributing! See below my 1 comment. On 25/04/2018 19:52, Kirill Shcherbatov wrote: > Branch: http://github.com/tarantool/tarantool/tree/gh-3272-no-sql-names > Issue: https://github.com/tarantool/tarantool/issues/3272 Please, provide a description of the patchset. > > Kirill Shcherbatov (4): > sql: Fix code style in sqlite3Pragma. > sql: Remove zName and nColumn from SQL. > sql: Removed type from SQL. > sql: Region-based allocations. > > src/box/space_def.c | 29 ++++--- > src/box/sql.c | 90 ++++++++++++++++--- > src/box/sql.h | 32 +++++++ > src/box/sql/alter.c | 32 ++++--- > src/box/sql/analyze.c | 5 +- > src/box/sql/build.c | 226 +++++++++++++++++++++++------------------------- > src/box/sql/delete.c | 6 +- > src/box/sql/expr.c | 11 +-- > src/box/sql/fkey.c | 20 ++--- > src/box/sql/insert.c | 55 ++++++------ > src/box/sql/pragma.c | 84 +++++++++--------- > src/box/sql/prepare.c | 26 +++--- > src/box/sql/resolve.c | 16 ++-- > src/box/sql/select.c | 120 ++++++++++++++----------- > src/box/sql/sqliteInt.h | 8 +- > src/box/sql/tokenize.c | 3 + > src/box/sql/trigger.c | 2 + > src/box/sql/update.c | 29 ++++--- > src/box/sql/util.c | 9 -- > src/box/sql/where.c | 6 +- > src/box/sql/wherecode.c | 2 +- > src/box/sql/whereexpr.c | 4 +- > 22 files changed, 477 insertions(+), 338 deletions(-) >