From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 9B9F76C7D2; Thu, 11 Feb 2021 09:50:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9B9F76C7D2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1613026237; bh=Ox3Rk/cIYZfmNp/JAGUCb7/EWSevPIsXDNFvz4/2uUY=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=vnQTdRhqWpxY6Y/eYMs77LCOuB0JSCUHPeQufjmsxcVh6nw9PcsvCn6CC1nExC3Kp sSVBnBlxVOuzQRa19L8Z3xqgUPkz0ZUZdopHL66gh+T9HMYaZS9P7/AwrEmTQV2dbL GNgOHDRUW/TBkyYL2WqwfNrTvOV5s49iuFSqm+L4= Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9D0E76C7D2 for ; Thu, 11 Feb 2021 09:50:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9D0E76C7D2 Received: by smtp3.mail.ru with esmtpa (envelope-from ) id 1lA5nn-0001O6-Nm; Thu, 11 Feb 2021 09:50:12 +0300 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@tarantool.org References: <4436bd47-7656-340d-31c3-de4146ab6aa6@tarantool.org> Message-ID: <14be86b4-c7ef-9726-9ecc-a7280b55feea@tarantool.org> Date: Thu, 11 Feb 2021 09:50:11 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD953AC099BC0052A9C3D690943982D6E894AC6DB5C833CB876182A05F538085040DB4C18C308606FBE7D5CFA8CCB3DFCBDF5473DB24220A071729CAD7BD4762644 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE731D82F3F177D3BCDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006376602C647E39EFA3A8638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC7BF04B2A11D85FC6D1E6803872B04A995770AD7DC00288A6389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0D9442B0B5983000E8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B65FF0BFC5AEE34BE6CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249A75142496D4D881D76E601842F6C81A12EF20D2F80756B5F7E9C4E3C761E06A776E601842F6C81A127C277FBC8AE2E8BA53C922A831C7DB53AA81AA40904B5D9DBF02ECDB25306B2B25CBF701D1BE8734AD6D5ED66289B5278DA827A17800CE70AD1028CF10412FC93EC92FD9297F6715571747095F342E857739F23D657EF2BD5E8D9A59859A8B698B1B85E56A716AC089D37D7C0E48F6C5571747095F342E857739F23D657EF2B6825BDBE14D8E7028C9DFF55498CEFB0BD9CCCA9EDD067B1EDA766A37F9254B7 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24A6D60772A99906F8E1CD14B953EB46D7FCFB4E98FF8BC06355D89D7DBCDD132 X-C1DE0DAB: 0D63561A33F958A5DE1ADDE02FDD5807C4F04642133E7CBA980DA2E0B7E4679ED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75448CF9D3A7B2C848410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AAC3D1FDB34D04886CABE7EF8A56092FA0031CED14A4B0A252ADBD6615D676093A9DCDD212B6304F1D7E09C32AA3244C61CA0E5BADAB52686BD66200EFDF6F653E8609A02908F271FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojmjFTaBTEi1arBXEfhnvTvA== X-Mailru-Sender: 583F1D7ACE8F49BD9317CE1922F30C7E670E60452F064E9CEEEBA6061C96211AE89CB45B1CA6C12523E75C7104EB1B885DEE61814008E47C7013064206BFB89F93956FB04BA385BE9437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 3/9] test: introduce a helper to wait for bucket GC X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Oleg Babin via Tarantool-patches Reply-To: Oleg Babin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for your answer. Yes, it's fine. LGTM. On 11/02/2021 01:33, Vladislav Shpilevoy wrote: > Thanks for the review! > > On 10.02.2021 09:57, Oleg Babin wrote: >> Hi! Thanks for your patch! LGTM but I have one question. >> >> Maybe it's reasonable to add some timeout in this function? >> >> AFAIK test-run terminates tests after 120 seconds of inactivity it seems too long for such simple case. >> >> But anyway it's up to you. > test_run:wait_cond() has default timeout 1 minute. I decided it > is fine.