From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 1044A30581 for ; Thu, 6 Jun 2019 20:38:49 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LApNNo6XXng1 for ; Thu, 6 Jun 2019 20:38:49 -0400 (EDT) Received: from smtp18.mail.ru (smtp18.mail.ru [94.100.176.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 5E08130552 for ; Thu, 6 Jun 2019 20:38:48 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: do not show additional generated ids From: "n.pettik" In-Reply-To: Date: Fri, 7 Jun 2019 03:38:44 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <14D3EEAF-2501-4BDC-82B6-C0BD3729C57A@tarantool.org> References: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Imeev Mergen > On 29 May 2019, at 20:09, imeevma@tarantool.org wrote: >=20 > Currently, if INSERT is executed by a trigger, the new generated > identifiers will be stored in the VDBE. This is wrong, and this > patch fixes it. Why is it so? > Only identifiers generated during INSERT run by > the user will be saved. Firstly, I truly do not understand why this behaviour is considered to be buggy. I don=E2=80=99t see discussion or bug description. Secondly, I do not understand what happens in this patch. Could you please explain these changes and argue why they are needed?