From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id AAD0C26A91 for ; Fri, 2 Aug 2019 06:02:50 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e5fo_miwf4Ck for ; Fri, 2 Aug 2019 06:02:50 -0400 (EDT) Received: from smtp18.mail.ru (smtp18.mail.ru [94.100.176.155]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 37AE526A90 for ; Fri, 2 Aug 2019 06:02:48 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: [tarantool-patches] Re: [PATCH 1/2] sql: extend struct Mem with field_type member From: "n.pettik" In-Reply-To: <1413d8ef-6f4f-293e-a10d-56d8d90022f7@tarantool.org> Date: Fri, 2 Aug 2019 13:02:45 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <149DE8FA-9A0F-4853-B42C-99EF9CE9711C@tarantool.org> References: <8be21965-b8ef-4f96-8ce3-99c2efcecfc0@tarantool.org> <351df50f-d096-45de-0d04-c9cee83d1289@tarantool.org> <9DC6E648-2C15-4C1C-A2B3-AEA174FA7CD3@tarantool.org> <1413d8ef-6f4f-293e-a10d-56d8d90022f7@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Vladislav Shpilevoy > My review fixes, on top of the branch. If you apply them, then LGTM. > Otherwise give me your comments, and we will continue the work (it > won't be LGTM then, *Kirill*, don't push!). Ok, thanks, they look OK to me so I I=E2=80=99ve squashed them.