From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DDD88219D2
	for <tarantool-patches@freelists.org>; Wed, 25 Apr 2018 11:44:28 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id TaaWu74VWBzV for <tarantool-patches@freelists.org>;
	Wed, 25 Apr 2018 11:44:28 -0400 (EDT)
Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9C71B219B8
	for <tarantool-patches@freelists.org>; Wed, 25 Apr 2018 11:44:28 -0400 (EDT)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: [tarantool-patches] Re: [PATCH v3] sql: remove support of partial
 indexes
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <20180425151745.zanpo6opqsmh3dhz@tkn_work_nb>
Date: Wed, 25 Apr 2018 18:44:25 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <14828071-C85D-4C6A-A985-5372A74A9E61@tarantool.org>
References: <1524654044-17949-1-git-send-email-gleb-skiba@mail.ru>
 <20180425151745.zanpo6opqsmh3dhz@tkn_work_nb>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Alexander Turenko <alexander.turenko@tarantool.org>, gleb-skiba@mail.ru, =?utf-8?B?0JrQuNGA0LjQu9C7INCu0YXQuNC9?= <kyukhin@tarantool.org>


> LGTM. Nikita, can you look?

Hello. Generally speaking, patch looks OK to me as well.

I don=E2=80=99t like error message: it is possible to make it more
intelligible. To do it, you need to left parser as is, but in
sqlite3CreateIndex() check that =E2=80=98WHERE=E2=80=99 arg is empty.
On the other hand, this is temporary ban and to enable this
feature back, it is enough to revert this patch, so never mind.=