From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E51C36EC40; Mon, 5 Jul 2021 12:23:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E51C36EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625477030; bh=xTtrqhqbGCOuM21wvLimiKdoiHeUaLXgEI4aOXY4Wp0=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=ioiE4mhUH4Uxw+1PuZEHs2iebInXcr6jJY4cKlRDVt8xPpXDjJgflTOCUFmgybtL4 /Z2Jyo48HfMxxZyezshPSwrbP92AGbDyT+AzCwx/352hW8+Y7saOs+K7soBKfU58Xg eF3nHEbN0bL3Aug6TAxfROmnH2gZ/CIj+s75rXZw= Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D40DC6EC40 for ; Mon, 5 Jul 2021 12:23:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D40DC6EC40 Received: by smtp3.mail.ru with esmtpa (envelope-from ) id 1m0KpP-0007ju-Vl; Mon, 05 Jul 2021 12:23:48 +0300 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@tarantool.org References: <888cee3d83fff78411e0cf96ee6b2e8292887677.1625177221.git.v.shpilevoy@tarantool.org> <85b44610-ba58-75af-07ec-7ae4dc66d372@tarantool.org> Message-ID: <14611499-0c7e-4030-f6ea-d0ef3c8c747d@tarantool.org> Date: Mon, 5 Jul 2021 12:23:47 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FB2F1AA0EB8A504C8721532AB396CDCF09182A05F538085040359F00E3BA0320C9E7EA4834B209EF5CDCA330011ECF521973D346D7FEC8E1DB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BC08626EA5717D14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375AC38C7EC4509C8B8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8F4D634E516DFB59479311CCF7E658FA1117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF80095D1E77F4578A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520B1593CA6EC85F86D2CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE4B6963042765DA4BA5FD2DD08EB4836CD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE39E541A154B51D14B6136E347CC761E07C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637A7EFCB0EB5ACB161EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5F7E4B377C6861113F24175121696817110E6FB763EB329F1D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7569E77FCA7B33833F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C53D1911AD7E41997C495281C59E75E4E4F366BA04D2EBE2A3EAD86FAB26D0281170C02CA41963D51D7E09C32AA3244CA60F3B1016D6823E9C56D90B34ADA576250262A5EE9971B0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj5fH2RN9TpJm0yXPoIZszew== X-Mailru-Sender: 583F1D7ACE8F49BD07526C4546A62CBFF892DC3EE7D0C801F9646260E3D578B8A47F5241C944308A23E75C7104EB1B885DEE61814008E47C7013064206BFB89F93956FB04BA385BE9437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH vshard 4/6] config: introduce master 'auto' replicaset option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Oleg Babin via Tarantool-patches Reply-To: Oleg Babin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for your change. LGTM. On 03.07.2021 00:32, Vladislav Shpilevoy wrote: > Hi! Thanks for the extensive review! > >>> +local function check_replicaset_master(master, ctx) >>> +    if not lutil.version_is_at_least(1, 10, 0) then >>> +        error('Only versions >= 1.10 support master discovery') >>> +    end >> If we talk about "is_async" netbox option. We should check 1.10.1: >> >> https://github.com/tarantool/tarantool/commit/0f686829a89b87d4f8d10fd25d4acfdea9b3dc60#diff-1e545a3af3d3592423eff523367e962e18f7eda45c2f9bef6994a254f6044d70 >> >> There is a gap between 1.10.0 and 1.10.1 when there is no is_async. > Good call. It is easy to fix so I did it: > > ==================== > @@ -22,8 +22,9 @@ local function check_replica_master(master, ctx) > end > > local function check_replicaset_master(master, ctx) > - if not lutil.version_is_at_least(1, 10, 0) then > - error('Only versions >= 1.10 support master discovery') > + -- Limit the version due to extensive usage of netbox is_async feature. > + if not lutil.version_is_at_least(1, 10, 1) then > + error('Only versions >= 1.10.1 support master discovery') > end > if master ~= 'auto' then > error('Only "auto" master is supported')