From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 233734696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  3 Apr 2020 17:21:32 +0300 (MSK)
References: <20200403093902.GA42848@pony.bronevichok.ru>
From: Oleg Babin <olegrok@tarantool.org>
Message-ID: <141ac7a3-45c6-a720-a400-d3d699443550@tarantool.org>
Date: Fri, 3 Apr 2020 17:21:30 +0300
MIME-Version: 1.0
In-Reply-To: <20200403093902.GA42848@pony.bronevichok.ru>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH] Fix luacheck warnings in
 src/lua/*.lua
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Bronnikov <sergeyb@tarantool.org>, tarantool-patches@dev.tarantool.org, avtikhon@tarantool.org, alexander.turenko@tarantool.org, o.piskunov@tarantool.org

Hi! Thanks for your patch!

I think not only "src/lua/*.lua" should be checked but also 
"src/box/lua/*.lua".

Also see one comment.

On 03/04/2020 12:39, Sergey Bronnikov wrote:
> diff --git a/src/lua/tap.lua b/src/lua/tap.lua
> index 94b080d5a..04497386e 100644
> --- a/src/lua/tap.lua
> +++ b/src/lua/tap.lua
> @@ -53,7 +53,7 @@ local function ok(test, cond, message, extra)
>       io.write(string.format("not ok - %s\n", message))
>       extra = extra or {}
>       if test.trace then
> -        local frame = debug.getinfo(3, "Sl")
> +        debug.getinfo(3, "Sl")

I think debug.getinfo() could be completely removed. It doesn't change 
any state it only returns some debug information that is completely unused.

---
Oleg Babin