From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DC9C025408 for ; Fri, 13 Sep 2019 18:28:50 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KHT9EC_XAqfK for ; Fri, 13 Sep 2019 18:28:50 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9793525407 for ; Fri, 13 Sep 2019 18:28:50 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v2 0/4] Serializer bugs References: <20190912234401.5mwym6khahljjcf7@tkn_work_nb> From: Vladislav Shpilevoy Message-ID: <1413867c-d2aa-f9d5-9d88-2f4b4943b3b3@tarantool.org> Date: Sat, 14 Sep 2019 00:32:40 +0200 MIME-Version: 1.0 In-Reply-To: <20190912234401.5mwym6khahljjcf7@tkn_work_nb> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Alexander Turenko Cc: tarantool-patches@freelists.org Hi! Thanks for the review! On 13/09/2019 01:44, Alexander Turenko wrote: > On Mon, Sep 09, 2019 at 09:00:06PM +0200, Vladislav Shpilevoy wrote: >> The patchset fixes several problems about JSON and msgpack serializers. >> >> 1) msgpackffi didn't use msgpack serializer options; >> 2) tuple serializer either; >> 3) update of a serializer option was not reflected in its Lua representation; >> 4) during serialization too nested tables are silently cropped and there was no >> way to prevent it. >> >> Also it was discovered, that msgpackffi does not care *all* options. Not only >> about max_depth. I am not sure if it is worth fixing here (or at all) though. > > I would not do it here. However it worth to file a follow up issue: we > should either fix or document this behaviour. It seems that it may be > very unexpected that space:update / upsert does not follow, say, > encode_invalid_numbers (if a user use this option and see that it works > for other box functions). https://github.com/tarantool/tarantool/issues/4499