From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id F23472CEEB
	for <tarantool-patches@freelists.org>; Mon,  3 Dec 2018 08:48:58 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id NZstNnVlyQ7j for <tarantool-patches@freelists.org>;
	Mon,  3 Dec 2018 08:48:58 -0500 (EST)
Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 4550A2CBF4
	for <tarantool-patches@freelists.org>; Mon,  3 Dec 2018 08:48:58 -0500 (EST)
Subject: [tarantool-patches] Re: [PATCH 1/2] sql: add CHAR description without
 length
References: <20181201011251.30573-1-roman.habibov@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <13ceb572-2260-49b0-f16a-efa8aafc0087@tarantool.org>
Date: Mon, 3 Dec 2018 16:48:51 +0300
MIME-Version: 1.0
In-Reply-To: <20181201011251.30573-1-roman.habibov@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, Roman Khabibov <roman.habibov@tarantool.org>

Hi! Thanks for the patch!

Please, sending a patchset consisting from multiple
commits send a cover-letter too. Branch and Issue
links should be there.

No cover-letter is ok only for single-commit patches.

Talking about functional part - it is ok. But I've
pushed one preparation patch before your:

commit 7c0ef3cc962ce5724485b18c0da014625920bf3e
Author: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Date:   Mon Dec 3 16:16:51 2018 +0300

     sql: store CHAR|VARCHAR len as integer, not type_def


Please, send all the 3 commits as v2 thread to Nikita for
a second review.