From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3D3D8258AF for ; Thu, 5 Apr 2018 07:20:55 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YUoxBbnN_ZL0 for ; Thu, 5 Apr 2018 07:20:55 -0400 (EDT) Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id F314B20655 for ; Thu, 5 Apr 2018 07:20:54 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 2/2] sql: rework 'DROP INDEX' and 'DROP TABLE' handling References: <2bccf40f38d3e3e3d2182c6c8111050770d69821.1522769126.git.korablev@tarantool.org> <69bcb5b2-34b5-5c64-31b3-016d9a699348@tarantool.org> <24260C14-041C-4F08-AC1B-B3F6ABBBA679@tarantool.org> From: Vladislav Shpilevoy Message-ID: <137d6ef1-c61f-f7e0-751c-2f0dca4d294d@tarantool.org> Date: Thu, 5 Apr 2018 14:20:52 +0300 MIME-Version: 1.0 In-Reply-To: <24260C14-041C-4F08-AC1B-B3F6ABBBA679@tarantool.org> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, "n.pettik" LGTM. 04.04.2018 21:11, n.pettik пишет: > >> On 3 Apr 2018, at 21:27, Vladislav Shpilevoy >> > wrote: >> >> See 6 comments below. >> >> 03.04.2018 19:14, Nikita Pettik пишет: >>> As a part of SQL data dictionary integration, 'DROP INDEX' and >>> 'DROP TABLE' statements proccessing has been refactored in order >>> to avoid using SQL specific internal structures. >>> However, triggers still aren't transfered to server, so to drop them >>> it is required to lookup SQL table and emit apporpriate opcodes. >>> Also, added comments and fixed codestyle for functions processing >>> 'DROP' routine. >>> >>> Part of #3222. >>> --- >>>  src/box/sql/build.c     | 241 >>> ++++++++++++++++++++++++++---------------------- >>>  src/box/sql/parse.c     |   6 +- >>>  src/box/sql/parse.y     |   6 +- >>>  src/box/sql/sqliteInt.h |   6 +- >>>  4 files changed, 140 insertions(+), 119 deletions(-)