From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 7E6996FC86; Wed, 24 Mar 2021 16:20:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 7E6996FC86 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1616592053; bh=zQDUIyYZkIF1bZX/CpWIBvasTNgXexVKu32Zh4exZ1M=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=xCAEMRFefIc88pAcCNS/cYy75Jgzz7b1U17+qQctTpV/bmOmsHMcm2mLSyrXwZPD1 ea5FsP6B+xFlmLx9Pna+F3IWwEntwuIG36ezw22bkm0r2jMnR/TozSjZQpbTS68DB8 89Hsej+etji+w+U4+mI6s5TTWxGGlfOAZE0/7G+c= Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B733A6FC86 for ; Wed, 24 Mar 2021 16:20:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B733A6FC86 Received: by smtp55.i.mail.ru with esmtpa (envelope-from ) id 1lP3RK-0006Oi-HC; Wed, 24 Mar 2021 16:20:50 +0300 To: Cyrill Gorcunov , tml References: <20210323154710.1696442-1-gorcunov@gmail.com> <20210323154710.1696442-3-gorcunov@gmail.com> Message-ID: <135ceac2-d74c-a2fe-13ab-aa73c379c11a@tarantool.org> Date: Wed, 24 Mar 2021 16:20:50 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210323154710.1696442-3-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD95D6E7CC48CB1F5F111116110879554077ED795A4341E98F3182A05F5380850406EA6ED5E4793EA1ABFECD1AA82D71964EE84077E1B74DDCF9FCE964A3424D80E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7B2CE06D3E4B8AFEBEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637C8BD49B17AF1FC7C8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C5DD32608FC869F5D9235F9E4AA28B593BEBD833406424674A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7E688A9D963DC14319FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C33B72D73EA5828B68117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CFA3592C56ED7E258CBA3038C0950A5D36C8A9BA7A39EFB766EC990983EF5C0329BA3038C0950A5D36D5E8D9A59859A8B6AF06177CD8E4C10F76E601842F6C81A1F004C906525384307823802FF610243DF43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B3BBE47FD9DD3FB59A8DF7F3B2552694A2BEBFE083D3B9BA73A03B725D353964BB11811A4A51E3B096D1867E19FE14079BA9C0B312567BB23089D37D7C0E48F6CA18204E546F3947CF841BD135A60A31742539A7722CA490CC8A9BA7A39EFB7666BA297DBC24807EA089D37D7C0E48F6C8AA50765F7900637E52AE9B802B2390DEFF80C71ABB335746BA297DBC24807EA27F269C8F02392CD20465B3A5AADEC6827F269C8F02392CD5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A5FBC7934A8E77D53EF20A9A8BE19B23506634DF165573EFD8D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34D71B56C992F8AF19C26126177451B409298B24CC716702A63A6515591E54AD18C048E9E4BCBECB2F1D7E09C32AA3244CD4329D5A82F4C77377894D782E9AE8C895A9E0DC41E9A4CF927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojNqBGwjEnRoWjVS2Rp0Qbgw== X-Mailru-Sender: 583F1D7ACE8F49BDD2846D59FC20E9F8DB2B39A6B8686E8F19321E37E5953F2A1424BECBD1EB7201424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 2/3] test: add a test for wal_cleanup_delay option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Cc: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 23.03.2021 18:47, Cyrill Gorcunov пишет: > +-- Wait error to appear. > +test_run:wait_log('master', 'XlogGapError', 1024, 0.1) ~= nil Thanks for the patch! You should wait more here. Like, 10 seconds, I think. Otherwise the test will probably flaky fail on CI. Most our wait for at most N seconds until condition calls end up with 10 second timeout (or bigger). > + > +-- > +-- Cleanup. > +test_run:cmd('stop server master') > +test_run:cmd('stop server replica') > +test_run:cmd('delete server master') > +test_run:cmd('delete server replica') > + > +-- > +-- Case 2. > +-- > +-- Lets make sure we're not getting XlogGapError in > +-- case if wal_cleanup_delay is used the code is almost > +-- the same as for Case 1 except we don't disable cleanup > +-- fiber but delay it up to a hour until replica is up > +-- and running. > +-- > + > +test_run:cmd('create server master with script="replication/gh-5806-master.lua"') > +test_run:cmd('start server master with args="3600", wait=True, wait_load=True') > + > +test_run:switch('master') > +box.schema.user.grant('guest', 'replication') > + > +box.cfg{checkpoint_count = 1} > + > +engine = test_run:get_cfg('engine') > +s = box.schema.space.create('test', {engine = engine}) > +_ = s:create_index('pk') > + > +test_run:switch('default') > +test_run:cmd('create server replica with rpl_master=master,\ > + script="replication/gh-5806-slave.lua"') > +test_run:cmd('start server replica with wait=True, wait_load=True') > + > +test_run:switch('replica') > +box.cfg{checkpoint_count = 1} > +s = box.schema.space.create('testreplica') > +_ = s:create_index('pk') > +box.space.testreplica:insert({1}) > +box.snapshot() > + > +test_run:switch('default') > +test_run:cmd('stop server replica') > + > +test_run:switch('master') > +box.space.test:insert({1}) > +box.snapshot() > + > +test_run:switch('default') > +test_run:cmd('restart server master with args="3600", wait=True, wait_load=True') > +test_run:switch('master') > +box.space.test:insert({2}) > +box.snapshot() > +assert(box.info.gc().is_paused == true) > + > +test_run:switch('default') > +test_run:cmd('start server replica with wait=True, wait_load=True') > + > +-- > +-- Make sure no error happened. > +assert(test_run:grep_log("master", "XlogGapError") == nil) > + > +test_run:cmd('stop server master') > +test_run:cmd('stop server replica') > +test_run:cmd('delete server master') > +test_run:cmd('delete server replica') -- Serge Petrenko