From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 07382253CE for ; Tue, 13 Aug 2019 04:28:23 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mt6Z-GCuDoUC for ; Tue, 13 Aug 2019 04:28:22 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id BC594253A1 for ; Tue, 13 Aug 2019 04:28:22 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v2 3/8] sql: wrap all trim functions in dispatcher References: <74a116ac889583f76d8617d644f6277073f9fbdd.1565275469.git.kshcherbatov@tarantool.org> From: Kirill Shcherbatov Message-ID: <1343677b-60e2-475d-7e08-e8f90898917e@tarantool.org> Date: Tue, 13 Aug 2019 11:28:16 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: "n.pettik" , Tarantool MailList >> A new dispatcher function trim_func calls corresponding trim_ >> function implementation in relation with number of argc - a count >> of arguments. >> >> This is an important stem to get rid of function's name > > Nit: stem -> step >> + >> +/** >> + * Normalize args from @a argv input array when it has one, >> + * two or three args. >> + * >> + * This is a dispatcher function that call corresponding > > Nit: call -> calls Fixed. >> + switch (argc) { >> + case 1: >> + trim_func_one_arg(context, argc, argv); > > Why not unpack arguments right here? > IMHO it would look much better. Can't understand, what do you mean? Those functions are static and would be inlined. They handle own corner case. Moreover, if I would unpack values externally, I need to pass three values (type, size, value) for each argument.