From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 59744F415D4; Tue, 18 Feb 2025 17:02:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 59744F415D4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1739887337; bh=X/G2T1oRqlx6TEUL4MFS1KsGJcG/0Y0kkQ7elXuaUyo=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=hLAJ14w5m5m9MWwOFEUtC+UlMGAjtmf3Si0CUNhoRNYdlZ9wQ9QKlgC2djM9oLkyO 6lYUsKQVjGIptShARCWgDngRjbVew1eeKD9YaAMcvzb3+pVmO/LDZynZPeKDBukUlS PxdXPMlkT0N3/x3XX/DAjMi8rpNxQy8ojGLfPydM= Received: from send263.i.mail.ru (send263.i.mail.ru [95.163.59.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id ECA126D60B0 for ; Tue, 18 Feb 2025 17:02:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ECA126D60B0 Received: by exim-smtp-844687bc8-wdv8n with esmtpa (envelope-from ) id 1tkOAw-000000004pE-2pE7; Tue, 18 Feb 2025 17:02:15 +0300 Content-Type: multipart/alternative; boundary="------------8f4lGi0tqMAOuC4I47FUguYH" Message-ID: <133c4a8d-ec29-42d8-86ae-4e5dc232d1ff@tarantool.org> Date: Tue, 18 Feb 2025 17:02:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun , Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org References: Content-Language: en-US In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD916C41472748AFA0499A5DCC2C2C98BDF5DC6DE94BD03B46E00894C459B0CD1B9004EE2440B4E31F8D4FF92D56319F197D255F7DD4B3ADF52C655D693D9056D6635340226AAA953E0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7227E4400968B082FEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063729381D024F10DD158638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D82450DE2BEEB8AE15B114BB478C65543B7A823FC7C1E408EBCC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC821E93C0F2A571C7BF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C2A336C6518635091AD7EC71F1DB884274AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C36F560EC7065075D7BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF17B107DEF921CE791DD303D21008E298D5E8D9A59859A8B6D082881546D9349175ECD9A6C639B01B78DA827A17800CE73349F3DFB73D9B11731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A573F78CECE5D73D4C5002B1117B3ED69637CEFE186B73722BC66B2B37046EC955823CB91A9FED034534781492E4B8EEAD27E9584FBD6BDD31BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D344A431191C56981FE4AB60154D55BC7AD7FB2DF64343E0AD79BBC583F952A009F137C3D674E2357211D7E09C32AA3244CF3EF0AD68565446477DD89D51EBB7742B646F39EBE279C2CEA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVWiyXSWEEqdrPCKC2RJqmn0= X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F25884588B69DF2C8CCA649CDF237C39DF130474EA387898300B860E8D52D8A803B3004D645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/7] sysprof: align test title with test filename X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------8f4lGi0tqMAOuC4I47FUguYH Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, Sergey, thanks for review. On 18.02.2025 14:10, Sergey Kaplun via Tarantool-patches wrote: > Hi, Sergey! > Thanks fro the patch! > LGTM, except a minor nits below. > >> sysprof: align test title with test filename > It should be `test:`, since we don't change the sysprof component > itself, only test for it. Fixed. > On 13.02.25, Sergey Bronnikov wrote: >> The patch fixes TAP test title to make it aligned with test >> filename. Inconsistency introduced in commit >> efd7e1a67de24464e1e83793e16eac6df443e3c0 >> ("test: make skipcond helper more convenient"). > I am afraid that this naming was introduced in the first commit related > to the tests (sysprof and memprof). No. The test introduced in 2593a9f83072ca999d5f528e1da481e8ba51d5b8, when test titles were not supported. >> --- >> test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua | 2 +- > Should it be fixed for the memprof too? Fixed: --- a/test/tarantool-tests/profilers/misclib-memprof-lapi.test.lua +++ b/test/tarantool-tests/profilers/misclib-memprof-lapi.test.lua @@ -1,7 +1,7 @@  -- XXX: This comment is a reminder to reimplement memprof tests  -- assertions to make them more independent to the changes made.  local tap = require("tap") -local test = tap.test("misc-memprof-lapi"):skipcond({ +local test = tap.test("misclib-memprof-lapi"):skipcond({    ['Test requires JIT enabled'] = not jit.status(),    ['Disabled on *BSD due to #4819'] = jit.os == 'BSD',    ["Memprof is implemented for x86_64 only"] = jit.arch ~= "x86" and > >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua b/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua >> index 237143ad..32fa384c 100644 >> --- a/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua >> +++ b/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua > > >> -- >> 2.34.1 >> --------------8f4lGi0tqMAOuC4I47FUguYH Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi, Sergey,

thanks for review.

On 18.02.2025 14:10, Sergey Kaplun via Tarantool-patches wrote:
Hi, Sergey!
Thanks fro the patch!
LGTM, except a minor nits below.


sysprof: align test title with test filename

It should be `test:`, since we don't change the sysprof component
itself, only test for it.
Fixed.
On 13.02.25, Sergey Bronnikov wrote:

The patch fixes TAP test title to make it aligned with test
filename. Inconsistency introduced in commit
efd7e1a67de24464e1e83793e16eac6df443e3c0
("test: make skipcond helper more convenient").

I am afraid that this naming was introduced in the first commit related
to the tests (sysprof and memprof).

No. The test introduced in 2593a9f83072ca999d5f528e1da481e8ba51d5b8,

when test titles were not supported.


      

        
---
 test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua | 2 +-


      

      
Should it be fixed for the memprof too?

    

    
Fixed:

    
---
      a/test/tarantool-tests/profilers/misclib-memprof-lapi.test.lua

      +++ b/test/tarantool-tests/profilers/misclib-memprof-lapi.test.lua

      @@ -1,7 +1,7 @@

       -- XXX: This comment is a reminder to reimplement memprof tests

       -- assertions to make them more independent to the changes made.

       local tap = require("tap")

      -local test = tap.test("misc-memprof-lapi"):skipcond({

      +local test = tap.test("misclib-memprof-lapi"):skipcond({

         ['Test requires JIT enabled'] = not jit.status(),

         ['Disabled on *BSD due to #4819'] = jit.os == 'BSD',

         ["Memprof is implemented for x86_64 only"] = jit.arch ~= "x86"
      and

    

    

      



      

        
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua b/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua
index 237143ad..32fa384c 100644
--- a/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua
+++ b/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua


      

      
<snipped>



      

        
-- 
2.34.1



      

      

    

  
  


--------------8f4lGi0tqMAOuC4I47FUguYH--