Hi, Sergey,

thanks for review.

On 18.02.2025 14:10, Sergey Kaplun via Tarantool-patches wrote:
Hi, Sergey!
Thanks fro the patch!
LGTM, except a minor nits below.

sysprof: align test title with test filename
It should be `test:`, since we don't change the sysprof component
itself, only test for it.
Fixed.
On 13.02.25, Sergey Bronnikov wrote:
The patch fixes TAP test title to make it aligned with test
filename. Inconsistency introduced in commit
efd7e1a67de24464e1e83793e16eac6df443e3c0
("test: make skipcond helper more convenient").
I am afraid that this naming was introduced in the first commit related
to the tests (sysprof and memprof).

No. The test introduced in 2593a9f83072ca999d5f528e1da481e8ba51d5b8,

when test titles were not supported.


      
---
 test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua | 2 +-
Should it be fixed for the memprof too?

Fixed:

--- a/test/tarantool-tests/profilers/misclib-memprof-lapi.test.lua
+++ b/test/tarantool-tests/profilers/misclib-memprof-lapi.test.lua
@@ -1,7 +1,7 @@
 -- XXX: This comment is a reminder to reimplement memprof tests
 -- assertions to make them more independent to the changes made.
 local tap = require("tap")
-local test = tap.test("misc-memprof-lapi"):skipcond({
+local test = tap.test("misclib-memprof-lapi"):skipcond({
   ['Test requires JIT enabled'] = not jit.status(),
   ['Disabled on *BSD due to #4819'] = jit.os == 'BSD',
   ["Memprof is implemented for x86_64 only"] = jit.arch ~= "x86" and


 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua b/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua
index 237143ad..32fa384c 100644
--- a/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua
+++ b/test/tarantool-tests/profilers/misclib-sysprof-lapi.test.lua
<snipped>

-- 
2.34.1