From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 99B9B903D63; Tue, 19 Dec 2023 15:20:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 99B9B903D63 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1702988410; bh=x2Sdz9CrRu5Uy9qpZYct1tzN8ngy01ayE/W3zqj9zEg=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=S+3BKCoXBs1k2sZ6IcobSpOWNMK4qN6Y0SFs+FDhMW6uONRnS77cLfi8EOb2e+x4f x1o2mqST+B8L4pOVacSB/wj0S9kUSZH04qnMYWsD+GUwCUDd0eWEQ8VM9C1QjqiHgr bRa2eHUgvdTXMsYDjesSRocrO5Apbn2uXCt9C6Fw= Received: from smtp16.i.mail.ru (smtp16.i.mail.ru [95.163.41.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 11B92903D40 for ; Tue, 19 Dec 2023 15:20:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 11B92903D40 Received: by smtp16.i.mail.ru with esmtpa (envelope-from ) id 1rFZ4y-00D3hO-0m; Tue, 19 Dec 2023 15:20:08 +0300 Message-ID: <1316b983-884f-4124-bbf6-748fc5ebb356@tarantool.org> Date: Tue, 19 Dec 2023 15:20:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org, skaplun@tarantool.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD97533543916A0F71AD15911439ECC4B5E02235F2F5915E4EDCD62213F67905E7AB5D6E7EDF87A4019C76804F1C44B670233A886E19E62222E1E39E150AE5B0BE1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D77100FFB2844417EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063786D6A7D810B9582D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8DF537B96CB69C8B4BC21B73B2168BD68117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC55B19328CBC4F849A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C632EDEA9CD5989A39735652A29929C6C4AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C31DA0D137B259B101BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF27ED053E960B195E1DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C30B8B320EE581A76035872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A519C7BF1383D67157AB4A1285F362676C55B2F8746AAC91C1F87CCE6106E1FC07E67D4AC08A07B9B00A6B3CD6EB70C818BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF58B4446C816E8F458FBA2CB891ED4653E60F71332A7CD5CFB0DA0980A06D98AA3CC8565881B595B6E190DC598EAEA94F268C449A3720A7CF1DEE9253038A447FA74DFFEFA5DC0E7F02C26D483E81D6BE0DBAE6F56676BC7117BB6831D7356A2DEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojgGTRFEPoGBSMaUhQPBdqxw== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A76989924736223682977246422009AD04AC87D154BA7A9C8918EBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2 1/6] build: purge sysprof.collapse module X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! LGTM with a minor comment. I'm not sure "build" is a correct prefix for a small commit description. Probably "tools" reflects component better. On 12/6/23 21:55, Maxim Kokryashkin wrote: > This module became unused as a result of commit > tarantool/tarantool@e2851883cd4c23d41bd9aec23fad06fd10d39c45, > so it can be purged safely from the LuaJIT sources. > > Part of tarantool/tarantool#8700 > --- > tools/CMakeLists.txt | 6 ------ > tools/sysprof/collapse.lua | 3 --- > 2 files changed, 9 deletions(-) > delete mode 100755 tools/sysprof/collapse.lua > > diff --git a/tools/CMakeLists.txt b/tools/CMakeLists.txt > index b951f767..1dfc39e4 100644 > --- a/tools/CMakeLists.txt > +++ b/tools/CMakeLists.txt > @@ -60,9 +60,6 @@ if(LUAJIT_DISABLE_SYSPROF) > else() > add_custom_target(tools-parse-sysprof EXCLUDE_FROM_ALL DEPENDS > sysprof/parse.lua > - # TODO: This line is not deleted only for the sake of integrational > - # testing. It should be deleted in the next series. > - sysprof/collapse.lua > sysprof.lua > utils/bufread.lua > utils/symtab.lua > @@ -71,9 +68,6 @@ else() > > install(FILES > ${CMAKE_CURRENT_SOURCE_DIR}/sysprof/parse.lua > - # TODO: This line is not deleted only for the sake of integrational > - # testing. It should be deleted in the next series. > - ${CMAKE_CURRENT_SOURCE_DIR}/sysprof/collapse.lua > DESTINATION ${LUAJIT_DATAROOTDIR}/sysprof > PERMISSIONS > OWNER_READ OWNER_WRITE > diff --git a/tools/sysprof/collapse.lua b/tools/sysprof/collapse.lua > deleted file mode 100755 > index cac92f1a..00000000 > --- a/tools/sysprof/collapse.lua > +++ /dev/null > @@ -1,3 +0,0 @@ > --- FIXME: This file is not deleted only for the sake of > --- integrational testing. It should be deleted in the > --- next series.