From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 36B23469710 for ; Wed, 3 Jun 2020 01:47:29 +0300 (MSK) References: From: Vladislav Shpilevoy Message-ID: <12a78dfb-5e46-29e4-4812-454172db06e0@tarantool.org> Date: Wed, 3 Jun 2020 00:47:27 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 0/3] Merger's NULL defererence List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Turenko Cc: tarantool-patches@dev.tarantool.org Hi! Thanks for the patchset! I would also ask Igor for a review. Because the patchset does some manipulations with luaL names, and attempts to optimize Lua-C code. On 01/06/2020 20:10, Alexander Turenko wrote: > The first patch is a bunch of renames: I dropped luaL prefix from > several functions to highlight the contract: they can be called from > usual C code, w/o any requirements to pass or to place a Lua state > somewhere. > > The second patch just fixes NULL pointer dereference that occurs due to > the wrong assumption: I did think that fiber().storage.lua.stack is > always exists and non-NULL. > > The third commit is the optimization: it allows to don't create a new > Lua state in merger when possible. > > https://github.com/tarantool/tarantool/issues/4954 > Totktonada/gh-4954-fix-merger-segfault-full-ci Do we need a changelog? Bugfixes are visible behaviour change.