From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2376015D111A; Mon, 17 Nov 2025 17:10:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2376015D111A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1763388606; bh=LGtZDlmVKqdrKaE2stlEiJ6OUthl62ppei1244g4338=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=eiep8riPQAuxkVKlG1J2d81pN8fAW+Bz03w/hUsxODBrpnfI/vqFZCPe4VGfcaQYm /SyDB7dO+DlelN7/vo/4jzNWglVMdyGAz1bC3Fi6qiezhd3FS7tHzdlTWKhtAjQCFe FPyl600tQX4Tzgy5WHJCChQevkfyjggewtdjvli8= Received: from send57.i.mail.ru (send57.i.mail.ru [89.221.237.152]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D835215D111A for ; Mon, 17 Nov 2025 17:09:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D835215D111A Received: by exim-smtp-88cf54d45-p4v44 with esmtpa (envelope-from ) id 1vKzvB-0000000021q-3P1o; Mon, 17 Nov 2025 17:09:34 +0300 Content-Type: multipart/alternative; boundary="------------iTw0OxDjpD0timxgREOoYsJd" Message-ID: <1290518b-8821-4ee8-b29b-2273e4adcebb@tarantool.org> Date: Mon, 17 Nov 2025 17:09:24 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <84afa8ace5194b4eed8606bf45a6d0a52af53dfb.1761301736.git.skaplun@tarantool.org> In-Reply-To: <84afa8ace5194b4eed8606bf45a6d0a52af53dfb.1761301736.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9110BAFCBE6BD1D167AB5004BEA225D964407BC14E2B63626182A05F53808504085A5AA21CC6950693DE06ABAFEAF67050D051B2588A9F8EB61C9E0771A6A769C5D31DA4D2BDE68BB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70EEC24FFE855BCBBC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7811C3E343B302E2EEA1F7E6F0F101C67CDEEF6D7F21E0D1D9295C2E9FA3191EE1B59CA4C82EFA6587F3820D73BB8F60A94DF385D9AE5114ACC061EA8E1D98EDB117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18618001F51B5FD3F9D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE9647ADFADE5905B1F41620B44FB51B7DD8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3AD0E433DBF1FBFA36136E347CC761E07C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006377870F476E0DB9443EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5124595CBA93C7D405002B1117B3ED69698A0C5F345D026719E040399BDE4761E823CB91A9FED034534781492E4B8EEADA3FB0D9844EF8EC5BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3455AC8BF8E3153BA0A7C3B97154E703F287F9E3F5B8BE7D6BA4B8072B00DBFED2FEA21D138141C5051D7E09C32AA3244C7ECA68484C3884D577DD89D51EBB774252C9E241CF9F8DCDEA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVfFX+FmbwDW19SJHm5Yr/Ek= X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B5994D21E55608BCCE23DE06ABAFEAF67050D051B2588A9F8EBB7CBEF92542CD7C8795FA72BAB74744FC77752E0C033A69EA16A481184E8BB1C9B38E6EA4F046BE03A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 31/41] perf: add scimark-mc in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------iTw0OxDjpD0timxgREOoYsJd Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for the patch! LGTM with a minor comment below. I propose to add a small test description to a comment: SciMark is a popular benchmark, MC is a Monte Carlo Integration. Sergey On 10/24/25 13:50, Sergey Kaplun wrote: > This patch adds the aforementioned test with the use of the benchmark > framework introduced before. The default arguments are adjusted > according to the amount of cycles in the file. > The arguments to the script can be provided in the command line run. > > Checks are omitted since they were not present in the original suite, > plus the precise result value depends on the input parameter. > --- > perf/LuaJIT-benches/scimark-mc.lua | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > create mode 100644 perf/LuaJIT-benches/scimark-mc.lua > > diff --git a/perf/LuaJIT-benches/scimark-mc.lua b/perf/LuaJIT-benches/scimark-mc.lua > new file mode 100644 > index 00000000..d26b6e48 > --- /dev/null > +++ b/perf/LuaJIT-benches/scimark-mc.lua > @@ -0,0 +1,19 @@ > +local bench = require("bench").new(arg) > + > +local cycles = tonumber(arg and arg[1]) or 15e7 > + > +local benchmark > +benchmark = { > + name = "scimark_mc", > + -- XXX: The description of tests for the function is too > + -- inconvenient. > + skip_check = true, > + payload = function() > + local flops = require("scimark_lib").MC()(cycles) > + benchmark.items = flops > + end, > +} > + > +bench:add(benchmark) > + > +bench:run_and_report() --------------iTw0OxDjpD0timxgREOoYsJd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for the patch! LGTM with a minor comment below.

I propose to add a small test description to a comment:

SciMark is a popular benchmark, MC is a Monte Carlo Integration.

Sergey

On 10/24/25 13:50, Sergey Kaplun wrote:
This patch adds the aforementioned test with the use of the benchmark
framework introduced before. The default arguments are adjusted
according to the amount of cycles in the <scimark-2010-12-20.lua> file.
The arguments to the script can be provided in the command line run.

Checks are omitted since they were not present in the original suite,
plus the precise result value depends on the input parameter.
---
 perf/LuaJIT-benches/scimark-mc.lua | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 perf/LuaJIT-benches/scimark-mc.lua

diff --git a/perf/LuaJIT-benches/scimark-mc.lua b/perf/LuaJIT-benches/scimark-mc.lua
new file mode 100644
index 00000000..d26b6e48
--- /dev/null
+++ b/perf/LuaJIT-benches/scimark-mc.lua
@@ -0,0 +1,19 @@
+local bench = require("bench").new(arg)
+
+local cycles = tonumber(arg and arg[1]) or 15e7
+
+local benchmark
+benchmark = {
+  name = "scimark_mc",
+  -- XXX: The description of tests for the function is too
+  -- inconvenient.
+  skip_check = true,
+  payload = function()
+    local flops = require("scimark_lib").MC()(cycles)
+    benchmark.items = flops
+  end,
+}
+
+bench:add(benchmark)
+
+bench:run_and_report()
--------------iTw0OxDjpD0timxgREOoYsJd--