From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 84B0A2DFE6 for ; Mon, 27 May 2019 16:43:09 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 083oRIL-23LG for ; Mon, 27 May 2019 16:43:09 -0400 (EDT) Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id CFDBD2DFDB for ; Mon, 27 May 2019 16:43:08 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 0/3] Fix CAST operation References: From: Vladislav Shpilevoy Message-ID: <12397a47-c66a-5cbb-55f5-5457f5c767ec@tarantool.org> Date: Mon, 27 May 2019 23:43:05 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Nikita Pettik , Kirill Yukhin LGTM. On 21/05/2019 13:34, Nikita Pettik wrote: > Branch: https://github.com/tarantool/tarantool/tree/np/gh-4229-adjust-cast > Issue: https://github.com/tarantool/tarantool/issues/4229 > > This patch-set allows explicit conversion using CAST operator from REAL > to BOOLEAN and from string value containing quoted floating point > literal to INTEGER. Detailed explanation is provided in commit messages > and in issue description. > > Nikita Pettik (3): > sql: remove redundant conversion from OP_AddImm > sql: allow CAST operation from REAL to BOOLEAN > sql: allow CAST operation from quoted float to int > > src/box/sql/vdbe.c | 2 +- > src/box/sql/vdbemem.c | 12 ++++++++--- > test/sql/types.result | 54 ++++++++++++++++++++++++++++++++++++++++++++++++- > test/sql/types.test.lua | 11 ++++++++++ > 4 files changed, 74 insertions(+), 5 deletions(-) >