From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4578F28ADC
	for <tarantool-patches@freelists.org>; Tue, 28 Aug 2018 02:46:21 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id k-QUV0MU8aKS for <tarantool-patches@freelists.org>;
	Tue, 28 Aug 2018 02:46:21 -0400 (EDT)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 014E528A40
	for <tarantool-patches@freelists.org>; Tue, 28 Aug 2018 02:46:21 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v2 1/2] box: export mpstream
 methods to core
References: <cover.1535367103.git.kshcherbatov@tarantool.org>
 <426c34291ce7834cf224eaed82506564c066ff8e.1535367103.git.kshcherbatov@tarantool.org>
 <53a9fff6-61ff-cffc-6f9d-073cd38d6928@tarantool.org>
From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Message-ID: <1235e702-db1d-8a37-e1b3-b4817edadb26@tarantool.org>
Date: Tue, 28 Aug 2018 09:46:19 +0300
MIME-Version: 1.0
In-Reply-To: <53a9fff6-61ff-cffc-6f9d-073cd38d6928@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

Hi. Thank you for comments.
> 1. As I said in the previous review, reserve and
> reserve_slow are not split in two functions just
> for case. There is a reason. And your patch
> destroys the benefit of reserve/reserve_slow
> splitting. I paste it here:
Sorry for misunderstanding, I didn't catch this words. Only why does mpstream is a header-only library.
-void
-mpstream_flush(struct mpstream *stream);
+static inline void
+mpstream_flush(struct mpstream *stream)

-char *
-mpstream_reserve(struct mpstream *stream, size_t size);
+static inline char *
+mpstream_reserve(struct mpstream *stream, size_t size)

-void
-mpstream_advance(struct mpstream *stream, size_t size);
+static inline void
+mpstream_advance(struct mpstream *stream, size_t size)


> 2. It is not 'LUA' anymore.
Ok, fixed-#ifndef TARANTOOL_LUA_MPSTREAM_H_INCLUDED
-#define TARANTOOL_LUA_MPSTREAM_H_INCLUDED
+#ifndef TARANTOOL_MPSTREAM_H_INCLUDED
+#define TARANTOOL_MPSTREAM_H_INCLUDED