From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 4F8E346970E
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 15 Jan 2020 15:35:45 +0300 (MSK)
References: <20200110154805.94649-1-olegrok@tarantool.org>
 <20200115112639.4rlwuxssjcshj65c@tkn_work_nb>
From: Oleg Babin <olegrok@tarantool.org>
Message-ID: <11e9b97a-3f3a-b3b0-5276-6e51468552da@tarantool.org>
Date: Wed, 15 Jan 2020 15:35:42 +0300
MIME-Version: 1.0
In-Reply-To: <20200115112639.4rlwuxssjcshj65c@tkn_work_nb>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v3] error: add __concat method to
	error object
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: Oleg Babin <babinoleg@mail.ru>, tarantool-patches@dev.tarantool.org

Thanks!

I've changed commit message and force pushed it to the top of my branch:
https://github.com/tarantool/tarantool/tree/olegrok/4489-concat-for-errors

New commit message:

commit a9ad4bdfa51174223e0d10ef0b6a751fd15a6d8e (HEAD -> 
olegrok/4489-concat-for-errors, origin/olegrok/4489-concat-for-errors)
Author: Oleg Babin <babinoleg@mail.ru>
Date:   Fri Jan 10 18:35:03 2020 +0300

     error: add __concat method to error object

     Usually functions return pair `nil, err` and expected that err is 
string.
     Let's make the behaviour of error object closer to string
     and define __concat metamethod.

     The case of error "error_mt.__concat(): neither of args is an error"
     is not covered by tests because of #4723

     Closes #4489


On 15/01/2020 14:26, Alexander Turenko wrote:
> LGTM.
> 
> Just two minor comments re commit message.
> 

---
Oleg Babin