From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5E1FD469719
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 13 Nov 2020 13:11:06 +0300 (MSK)
References: <20201112195121.191366-1-gorcunov@gmail.com>
 <20201112195121.191366-10-gorcunov@gmail.com>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <11e6dccd-feba-e55c-4f0b-0d73e50d8b6d@tarantool.org>
Date: Fri, 13 Nov 2020 13:11:05 +0300
MIME-Version: 1.0
In-Reply-To: <20201112195121.191366-10-gorcunov@gmail.com>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [Tarantool-patches] [PATCH 09/11] qsync: drop redundant type
	convention
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>, tml <tarantool-patches@dev.tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>


12.11.2020 22:51, Cyrill Gorcunov пишет:
> Void pointer can be cast implicitly.

We usually use explicit casts. Check `applier.cc`, `alter.cc` and some 
other places.
This isn't in our style guide though, so I'm fine with the change.

Let's see what Vlad has to say.

>
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>   src/box/txn_limbo.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/src/box/txn_limbo.c b/src/box/txn_limbo.c
> index cf6122360..ffcda389c 100644
> --- a/src/box/txn_limbo.c
> +++ b/src/box/txn_limbo.c
> @@ -549,8 +549,7 @@ static int
>   txn_commit_cb(struct trigger *trigger, void *event)
>   {
>   	(void)event;
> -	struct confirm_waitpoint *cwp =
> -		(struct confirm_waitpoint *)trigger->data;
> +	struct confirm_waitpoint *cwp = trigger->data;
>   	cwp->is_confirm = true;
>   	fiber_wakeup(cwp->caller);
>   	return 0;
> @@ -560,8 +559,7 @@ static int
>   txn_rollback_cb(struct trigger *trigger, void *event)
>   {
>   	(void)event;
> -	struct confirm_waitpoint *cwp =
> -		(struct confirm_waitpoint *)trigger->data;
> +	struct confirm_waitpoint *cwp = trigger->data;
>   	cwp->is_rollback = true;
>   	fiber_wakeup(cwp->caller);
>   	return 0;

-- 
Serge Petrenko