From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 7E06523CCD
	for <tarantool-patches@freelists.org>; Mon,  7 May 2018 14:50:17 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Oqt3-6aDAqXr for <tarantool-patches@freelists.org>;
	Mon,  7 May 2018 14:50:17 -0400 (EDT)
Received: from forward1j.cmail.yandex.net (forward1j.cmail.yandex.net [5.255.227.19])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id D178722915
	for <tarantool-patches@freelists.org>; Mon,  7 May 2018 14:50:16 -0400 (EDT)
From: roman.habibov1@yandex.ru
In-Reply-To: <399639c2-dcd6-da4b-8402-f0ec10f3ea74@tarantool.org>
References: <aae0bec697872f421cf229b02ae3fc5f93a2b24e.1525474833.git.roman.habibov1@yandex.ru> <399639c2-dcd6-da4b-8402-f0ec10f3ea74@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] Tests for CREATE TEMP TABLE and CREATE TEMPORARY TABLE
MIME-Version: 1.0
Message-Id: <1154681525719011@web34j.yandex.ru>
Date: Mon, 07 May 2018 21:50:11 +0300
Content-Transfer-Encoding: 7bit
Content-Type: text/plain
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, "tarantool-patches@freelists.org" <tarantool-patches@freelists.org>

diff --git a/commits/1 b/commits/1
index 27ef2f6..dee20d6 100644

@@ -5,7 +5,7 @@ Date: Sat, 5 May 2018 01:45:06 +0300
 Subject: [PATCH v1 1/1] sql: tests for CREATE TEMP TABLE and  CREATE TEMPORARY
  TABLE

07.05.2018, 16:08, "Vladislav Shpilevoy" <v.shpilevoy@tarantool.org>:
> 1. Please, in the commit title write a Tarantool submodule prefix. For example,
> your patch is about SQL, so you would write 'sql: ' prefix.

diff --git a/test/sql-tap/table.test.lua b/test/sql-tap/table.test.lua
index 4882b18..21213bc 100755
--- a/test/sql-tap/table.test.lua
+++ b/test/sql-tap/table.test.lua
@@ -611,6 +611,9 @@ test:do_execsql2_test(
 --     SELECT * FROM [t4"abc];
 --   }
 -- } {cnt 1 max(b+c) 5}
+
+-- gh-2166 functions with TEMP and TEMPORARY are removed, tests needed to show that
+
 test:do_catchsql_test(
 	"temp",
 	[[

07.05.2018, 16:08, "Vladislav Shpilevoy" <v.shpilevoy@tarantool.org>:
>2. Before the test cases write in comments what do you test here, and
>:write a link to the issue in the format 'gh-NNNN: description'.