From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id F3A2D28C74 for ; Thu, 11 Apr 2019 13:22:16 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4WtZ9s7d0VOd for ; Thu, 11 Apr 2019 13:22:16 -0400 (EDT) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3BF03289A1 for ; Thu, 11 Apr 2019 13:22:16 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 1/1] swim: keep encoded round message cached References: <573c97faff11b387566fd449c1d1dcbe3e644351.1554893660.git.v.shpilevoy@tarantool.org> <20190411135150.GA5480@chai> <20190411162456.GB7446@chai> From: Vladislav Shpilevoy Message-ID: <1110c851-06ce-b2f8-3995-bea29b38c65f@tarantool.org> Date: Thu, 11 Apr 2019 20:22:13 +0300 MIME-Version: 1.0 In-Reply-To: <20190411162456.GB7446@chai> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Konstantin Osipov Cc: tarantool-patches@freelists.org Pushed to the master. On 11/04/2019 19:24, Konstantin Osipov wrote: > * Vladislav Shpilevoy [19/04/11 19:13]: > > OK to push. > >>> Are you going to add anything to this method? If not, please get >>> rid of it and inline swim_packet_create() to all relevant places, >>> with an appropriate comment. >> >> I am not going to change it now, but >> >> 1) I (or anyone else) can change my (their) mind in future. Even >> during SWIM development we already did it. I have this patch >> since the SWIM implementation was multi-packet, and invalidation >> of the cache was different. >> >> 2) This logic of recreating the packet is too internal to be >> inlined in all the usage places. I would rather comment this >> function and logic in one encapsulated place, and would just >> call it. > > They can easily re-introduce this function when necessary. > > -- > Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 > http://tarantool.io - www.twitter.com/kostja_osipov >