From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2D2334696C3 for ; Thu, 2 Apr 2020 12:14:37 +0300 (MSK) From: "Timur Safin" References: In-Reply-To: Date: Thu, 2 Apr 2020 12:14:35 +0300 Message-ID: <10e401d608cf$20ef8970$62ce9c50$@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Language: ru Subject: Re: [Tarantool-patches] [PATCH 0/4] session settings fixes List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: 'Chris Sosnin' , v.shpilevoy@tarantool.org, korablev@tarantool.org, tarantool-patches@dev.tarantool.org, Kirill Yukhin I'm late here on this party, but I very much dislike proposed syntax of SETTING SET configuration_name = value; It feels not SQL-ish, and I see no much value introducing new statement while there is still SET statement available. Why we could not simply use something like: SET box.session.settings.name = value; ? Thanks, Timur : -----Original Message----- : From: Tarantool-patches On : Behalf Of Chris Sosnin : Sent: Monday, March 30, 2020 12:14 PM : To: v.shpilevoy@tarantool.org; korablev@tarantool.org; tarantool- : patches@dev.tarantool.org : Subject: [Tarantool-patches] [PATCH 0/4] session settings fixes : : issue #1:https://github.com/tarantool/tarantool/issues/4711 : issue #2:https://github.com/tarantool/tarantool/issues/4712 : branch:https://github.com/tarantool/tarantool/tree/ksosnin/gh-4712- : session-settings-v2 : : Chris Sosnin (4): : box: replace session_settings modules with a single array : box: add binary search for _session_settings space : box: provide a user friendly frontend for accessing session settings : sql: provide a user friendly frontend for accessing session settings : : extra/mkkeywordhash.c | 1 + : src/box/lua/session.c | 111 +++++++++ : src/box/session.cc | 1 + : src/box/session.h | 2 + : src/box/session_settings.c | 214 +++++++++++------- : src/box/session_settings.h | 53 +++-- : src/box/sql.c | 5 - : src/box/sql/build.c | 104 ++++----- : src/box/sql/parse.y | 5 + : src/box/sql/sqlInt.h | 11 + : src/box/sql/vdbe.c | 50 ++++ : ...rontend.result => session_settings.result} | 147 ++++++++++-- : ...end.test.lua => session_settings.test.lua} | 61 ++++- : 13 files changed, 589 insertions(+), 176 deletions(-) : rename test/box/{gh-4511-access-settings-from-any-frontend.result => : session_settings.result} (71%) : rename test/box/{gh-4511-access-settings-from-any-frontend.test.lua => : session_settings.test.lua} (64%) : : -- : 2.21.1 (Apple Git-122.3)