From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5C0245C2D92; Mon, 28 Aug 2023 17:33:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5C0245C2D92 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1693233218; bh=V5MU9xk3hpUGU89fBSKsIix1HGIpJq53qkQxjU/WQWc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Hf0TxrEn69AK6xqC+7niUfDCBGw64smxB8MhqKG4B5pKQkJ5GZjqMpq9y43+/vjMF MJ73tdn/wKX9o8JVQ4r6WbSMrigctBR9f6I6KXMY8y9bkudLP7xfo+3AGVre/nkMnz x7R4MGZ8n2QuRjATRUuvyx4Ki6D/XMuqvGH+4mc0= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9B4895C2D87 for ; Mon, 28 Aug 2023 17:33:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9B4895C2D87 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1qadJA-0007C1-7h; Mon, 28 Aug 2023 17:33:37 +0300 Message-ID: <100dc157-f7ac-314e-0b84-c37cba9938a9@tarantool.org> Date: Mon, 28 Aug 2023 17:33:35 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Sergey Kaplun References: <20230817144641.20088-1-skaplun@tarantool.org> <5c416cf4-f366-9f35-f05b-13f1c7679749@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD96201AD55A1C8F7DB4B94316895B7D143959E6F65F85AE25C182A05F5380850404C228DA9ACA6FE277DD33F55DC13DAA9491A001011D33B29793B11E4BFDECF9A28515C535E4AFCD5 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76C0A440987CA342DC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7C2204D4F9A221771EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BE5CCB53A13BC8DBAD7F455D524DBDB406778752117B8468DCC7F00164DA146DAFE8445B8C89999728AA50765F7900637C6959D404C7CBA91389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8744B801E316CB65FF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE33AC447995A7AD182BEBFE083D3B9BA73A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735C8D5298E42E60C1FC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5653B69AEA12A10A4E544BC31C315E321E3851881C76758A2F87CCE6106E1FC07E67D4AC08A07B9B0FE4D9CDE3FF759CFCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3480665FBD8F49180CF65E18338E95AD4585EEC2178C06EA5CFA747DF40451701711FAF5551F0B04171D7E09C32AA3244C392A9F7DE6E40E135E7256EED1C2C5C2C86C126E7119A0FE85A42E4C463514DC5DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojrC6BcuK2ROz/ZHA5+Q9KOQ== X-DA7885C5: B006801B33FB0C6993A0412809BCFE57A2C37A27E8D6D762DD9BC0DD104A2578262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F73930F533AC2B33E986B347FD00745FD2D98A1817C0E4451D5CCDD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Fix TDUP load forwarding after table rehash. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" On 8/28/23 17:26, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Please, see my answers below. > > On 28.08.23, Sergey Bronnikov wrote: >> Sergey, >> >> >> thanks for the patch. See my comment inline. >> > > >> >> Is it possible to fold loop bodies to a single function? >> >> Otherwise it is too much duplicate code in the test. > I prefer not to do it since: > * It's complicated traces, so it's harder to understand what is this > test about. > * Some function's may be recorded instead, so the issue will not > occure. Or test becomes flaky. Okay, accepted. LGTM