From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tsafin@tarantool.org>
Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 776F8469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 19 Mar 2020 14:07:05 +0300 (MSK)
From: "Timur Safin" <tsafin@tarantool.org>
References: <bb3eef527b48bdd3aacddc27e0597ceedcb84987.1584371177.git.tsafin@tarantool.org>
 <0f1501d5fdd8$f21e6860$d65b3920$@tarantool.org>
 <20200319105204.GW27301@uranus>
In-Reply-To: <20200319105204.GW27301@uranus>
Date: Thu, 19 Mar 2020 14:07:03 +0300
Message-ID: <0f6901d5fdde$85392720$8fab7560$@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: 7bit
Content-Language: ru
Subject: Re: [Tarantool-patches] [PATCH v1.2] evio: workaround for wsl1
	so_linger assertion
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: 'Cyrill Gorcunov' <gorcunov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org, 'Vladislav Shpilevoy' <v.shpilevoy@tarantool.org>, 'Cyrill Gorcunov' <gorcunov@tarantool.org>



: -----Original Message-----
: From: Cyrill Gorcunov <gorcunov@gmail.com>
: Sent: Thursday, March 19, 2020 1:52 PM
: To: Timur Safin <tsafin@tarantool.org>
: Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>; tarantool-
: patches@dev.tarantool.org; Cyrill Gorcunov <gorcunov@tarantool.org>
: Subject: Re: [Tarantool-patches] [PATCH v1.2] evio: workaround for wsl1
: so_linger assertion
: 
: On Thu, Mar 19, 2020 at 01:27:08PM +0300, Timur Safin wrote:
: > SO_LINGER makes no much sense for unix-sockets, and Microsoft WSL
: > is returning EINVAL if setsockopts called for SO_LINGER over unix
: > sockets:
: >
: >   [004] 2020-03-11 18:42:29.592 [29182] main/102/app sio.c:169 !>
: SystemError setsockopt(SO_LINGER), called on fd 16, aka
: >   [004] 2020-03-11 18:42:29.592 [29182] main/102/app F> can't initialize
: storage: setsockopt(SO_LINGER), called on fd 16,
: >   [004] 2020-03-11 18:42:29.592 [29182] main/102/app F> can't initialize
: storage: setsockopt(SO_LINGER), called on fd 16,
: >
: > And it's sort of correct here, but the problem is Linux is simply
: > silently ignoring it, which passes tests.
: >
: > After much debates we decided to work-around this case via CMAKE
: > define.
: >
: > NB! In a future (April/May 2020), when WSL2 with full Linux kernel
: > would be released we should disable this check.
: 
: Hardly. This will break backward compatibility. Or we will have
: to _require_ WSL2 to build tarantool.

I'll find the proper way to distinguish WSL1/WSL2 by then. No problem.