Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Ostanevich <sergos@tarantool.org>,
	Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH luajit 1/3] test: remove excess dependency for tests target
Date: Mon,  5 Apr 2021 20:11:38 +0300	[thread overview]
Message-ID: <0f14e772231484f8ed786e499ac62be28dd2a484.1617641697.git.imun@tarantool.org> (raw)
In-Reply-To: <cover.1617641697.git.imun@tarantool.org>

TEST_DEPS list was introduced to prevent <tarantool-tests> target from
being run in case no dependencies are changed. As a result of review it
was decided to make all *-tests targets be .PHONY rules, hence TEST_DEPS
variable is excess and can be dropped.

Follows up tarantool/tarantool#4862

Signed-off-by: Igor Munkin <imun@tarantool.org>
---
 test/tarantool-tests/CMakeLists.txt | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt
index 9bb26f32..3e36ff86 100644
--- a/test/tarantool-tests/CMakeLists.txt
+++ b/test/tarantool-tests/CMakeLists.txt
@@ -69,7 +69,6 @@ set(LUA_PATH
 )
 set(LUA_TEST_SUFFIX .test.lua)
 set(LUA_TEST_FLAGS --failures --shuffle)
-file(GLOB TEST_DEPS ${CMAKE_CURRENT_SOURCE_DIR}/*${LUA_TEST_SUFFIX})
 
 if(CMAKE_VERBOSE_MAKEFILE)
   list(APPEND LUA_TEST_FLAGS --verbose)
@@ -78,7 +77,7 @@ endif()
 # LUA_CPATH and LD_LIBRARY_PATH variables and also TESTLIBS list
 # with dependecies are set in scope of BuildTestLib macro.
 add_custom_target(tarantool-tests
-  DEPENDS ${LUAJIT_TEST_BINARY} ${TESTLIBS} ${TEST_DEPS}
+  DEPENDS ${LUAJIT_TEST_BINARY} ${TESTLIBS}
 )
 add_custom_command(TARGET tarantool-tests
   COMMENT "Running Tarantool tests"
-- 
2.25.0


  reply	other threads:[~2021-04-05 17:12 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-05 17:11 [Tarantool-patches] [PATCH luajit 0/3] Fix out-of-source testing on MacOS Igor Munkin via Tarantool-patches
2021-04-05 17:11 ` Igor Munkin via Tarantool-patches [this message]
2021-04-06  7:38   ` [Tarantool-patches] [PATCH luajit 1/3] test: remove excess dependency for tests target Sergey Kaplun via Tarantool-patches
2021-04-06  8:02     ` Igor Munkin via Tarantool-patches
2021-04-06  9:51       ` Sergey Kaplun via Tarantool-patches
2021-04-06 15:38   ` Sergey Ostanevich via Tarantool-patches
2021-04-06 16:19     ` Igor Munkin via Tarantool-patches
2021-04-05 17:11 ` [Tarantool-patches] [PATCH luajit 2/3] test: make utils.selfrun usage easier Igor Munkin via Tarantool-patches
2021-04-06 13:01   ` Sergey Kaplun via Tarantool-patches
2021-04-06 13:35     ` Igor Munkin via Tarantool-patches
2021-04-06 16:22   ` Sergey Ostanevich via Tarantool-patches
2021-04-06 18:32     ` Igor Munkin via Tarantool-patches
2021-04-07 12:16       ` Sergey Ostanevich via Tarantool-patches
2021-04-05 17:11 ` [Tarantool-patches] [PATCH luajit 3/3] test: fix dynamic modules loading on MacOS Igor Munkin via Tarantool-patches
2021-04-06 17:02   ` Sergey Ostanevich via Tarantool-patches
2021-04-06 18:05     ` Igor Munkin via Tarantool-patches
2021-04-07 16:38   ` Sergey Kaplun via Tarantool-patches
2021-04-07 17:33     ` Igor Munkin via Tarantool-patches
2021-04-07 21:17 ` [Tarantool-patches] [PATCH luajit 0/3] Fix out-of-source testing " Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0f14e772231484f8ed786e499ac62be28dd2a484.1617641697.git.imun@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=sergos@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 1/3] test: remove excess dependency for tests target' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox