From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 942B96F87A; Wed, 28 Apr 2021 18:14:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 942B96F87A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1619622843; bh=i/Ljy+o4tWxIW6T/OQZY/NN+bYeAAOCk9bXx52hcXk8=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=T+0wtuaOYHbQTbQSjywe+38KrEx7/TVasA/h15W81NG2lyjc9jZXT/wx1KGHlTIEH YXCMbubmHtDUdr9SRaG+FRUXRYgNBNi+ucgL+ogGasZ67XvANHK9/rr5D3FM/UPWxO tvjWt0zaeNwjdZLJlvMpFWNd6gHPwMRza4vLF8q0= Received: from smtp30.i.mail.ru (smtp30.i.mail.ru [94.100.177.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2161C6F87A for ; Wed, 28 Apr 2021 18:13:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2161C6F87A Received: by smtp30.i.mail.ru with esmtpa (envelope-from ) id 1lblsp-0006NU-3r; Wed, 28 Apr 2021 18:13:47 +0300 To: Cyrill Gorcunov , tml References: <20210428102251.552976-1-gorcunov@gmail.com> <20210428102251.552976-2-gorcunov@gmail.com> Message-ID: <0efd166c-025e-bee5-0ad7-e8e827faa27a@tarantool.org> Date: Wed, 28 Apr 2021 18:13:46 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210428102251.552976-2-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: ru X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ECFD8CE5F0594010C798B26A9CF6FD3F37CC5E681187C6DF182A05F5380850405425053045A293EBB2703FAE10BFA08322A6FE259626FAE0706935AE7E20D1A4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE73B44982FA5E78411EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637889C00975665ABF68638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2C701881797B81BD979EA73837C10823F8E320D419CB56618D2E47CDBA5A96583C09775C1D3CA48CFED8438A78DFE0A9E117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE70F3DDF2BBF19B93A9FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE7C6A5C86E6400A7C2D32BA5DBAC0009BE395957E7521B51C20BC6067A898B09E4090A508E0FED6299176DF2183F8FC7C0A2E2240085632A06CD04E86FAF290E2D7E9C4E3C761E06A71DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6BF3059D42242344A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24209795067102C07E8F7B195E1C978315635A77B7D51D5198AB617A7AECA58CD X-C1DE0DAB: 0D63561A33F958A52CB673FFC69E8FF897439336C92549B95A70A1BD3F7B1934D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D342F9EE325F82A28A813D3B0AA2EC1E4592C1D722449CEF9D8A36A35F62658A0CF944AB6D9AC1158991D7E09C32AA3244C94BB8173B349FD76A30A6B39F7A80A503A76366E8A9DE7CA927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojoCaqxM2e5srfoEz+ewdLFA== X-Mailru-Sender: 583F1D7ACE8F49BDD2846D59FC20E9F84A4ABAEC5A1EFCDB14461BB53C02D2F3894F61FA741C4348424AE0EB1F3D1D21E2978F233C3FAE6EE63DB1732555E4A8EE80603BA4A5B0BC112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 1/2] fiber: fiber_join -- drop redundat variable X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Serge Petrenko via Tarantool-patches Reply-To: Serge Petrenko Cc: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" 28.04.2021 13:22, Cyrill Gorcunov пишет: > No need for additional variable here. > > In-scope-of #6046 > > Signed-off-by: Cyrill Gorcunov > --- > src/lib/core/fiber.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/src/lib/core/fiber.c b/src/lib/core/fiber.c > index cb6295171..a4b60e864 100644 > --- a/src/lib/core/fiber.c > +++ b/src/lib/core/fiber.c > @@ -614,8 +614,7 @@ fiber_reschedule(void) > int > fiber_join(struct fiber *fiber) > { > - int rc = fiber_join_timeout(fiber, TIMEOUT_INFINITY); > - return rc; > + return fiber_join_timeout(fiber, TIMEOUT_INFINITY); > } > > int Thanks! LGTM -- Serge Petrenko