From: Mergen Imeev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: s.ostanevich@corp.mail.ru, tsafin@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v2 1/2] sql: Initialize MEM in sqlVdbeAllocUnpackedRecord()
Date: Sat, 13 Feb 2021 18:38:29 +0300 [thread overview]
Message-ID: <0ef21d5f7e3f95927959e96ac3aeab2edcd4544b.1613230498.git.imeevma@gmail.com> (raw)
In-Reply-To: <cover.1613230498.git.imeevma@gmail.com>
This patch adds initialization for newly created MEM objects in
sqlVdbeAllocUnpackedRecord(). Changing a MEM without being
initialized may give us unexpected result.
Part of #4470
---
src/box/sql/vdbeaux.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/box/sql/vdbeaux.c b/src/box/sql/vdbeaux.c
index 91b64316e..5c2706e49 100644
--- a/src/box/sql/vdbeaux.c
+++ b/src/box/sql/vdbeaux.c
@@ -2329,6 +2329,8 @@ sqlVdbeAllocUnpackedRecord(struct sql *db, struct key_def *key_def)
if (!p)
return 0;
p->aMem = (Mem *) & ((char *)p)[ROUND8(sizeof(UnpackedRecord))];
+ for (uint32_t i = 0; i < key_def->part_count + 1; ++i)
+ sqlVdbeMemInit(&p->aMem[i], sql_get(), MEM_Null);
p->key_def = key_def;
p->nField = key_def->part_count + 1;
return p;
--
2.25.1
next prev parent reply other threads:[~2021-02-13 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-13 15:38 [Tarantool-patches] [PATCH v2 0/2] Encapsulate MEM type changing and checking Mergen Imeev via Tarantool-patches
2021-02-13 15:38 ` Mergen Imeev via Tarantool-patches [this message]
2021-02-13 15:38 ` [Tarantool-patches] [PATCH v2 2/2] sql: encapsulate setting type checking of MEM Mergen Imeev via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ef21d5f7e3f95927959e96ac3aeab2edcd4544b.1613230498.git.imeevma@gmail.com \
--to=tarantool-patches@dev.tarantool.org \
--cc=imeevma@tarantool.org \
--cc=s.ostanevich@corp.mail.ru \
--cc=tsafin@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/2] sql: Initialize MEM in sqlVdbeAllocUnpackedRecord()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox