From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <tarantool-patches-bounces@dev.tarantool.org> Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6AF896EC55; Tue, 27 Jul 2021 02:43:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6AF896EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627343038; bh=zw5NH43IdQE2AU5sBlue1w/T2QCu77SxD4fdF+lB09M=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=CMpCGNf0nlRSANLNq+LGM+HpeGWCbhnUx6HjCGZCp01Ub+jG8M8Zz7orJ5Q6fWR2x /loJosEw6gEyOMgHcRRxxe2jDy6nV1YmXwNKScEEIeJoIRdnL5VnJDdp25IWPeVpvu FMMbH+959TCOPlQ7SwNX5Pnt1fbIjCzdytYznjQQ= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id DD86A6EC55 for <tarantool-patches@dev.tarantool.org>; Tue, 27 Jul 2021 02:43:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DD86A6EC55 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from <v.shpilevoy@tarantool.org>) id 1m8AG4-0005xS-5u; Tue, 27 Jul 2021 02:43:40 +0300 To: Sergey Petrenko <sergepetrenko@tarantool.org>, gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org References: <cover.1626287002.git.sergepetrenko@tarantool.org> <de13e1f50454b0cf2cbcd2cdfeb5082e36c55ee6.1626287002.git.sergepetrenko@tarantool.org> <571af10d-1ce6-8f92-b5c2-48eafa3d7977@tarantool.org> <502885e7-8400-248e-9bcc-fcfa443cbb22@tarantool.org> Message-ID: <0e79aff6-6eca-3edb-6ed4-1f5a396dd53e@tarantool.org> Date: Tue, 27 Jul 2021 01:43:39 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <502885e7-8400-248e-9bcc-fcfa443cbb22@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD941C43E597735A9C351B198F4576AC7B21928AAE70459C21B182A05F538085040607333D885DB2AAF79E49C9610CD764A397920958D50DF04AA8C430F4A77C761 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7978947DCA0D4215FEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E16D8B060A9A23898638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D88E3F954F146ED08373D43AB811C3C86B117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3733B5EC72352B9FA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10F28451B159A507268D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B613439FA09F3DCB32089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B505B043F014BEAB095996F3FC92E90F29D1 X-C1DE0DAB: 0D63561A33F958A5325273F2815B706FE38341735686866BA6CA2ADE94B60A1CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA753530422897FB34C3410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A9873270276D43343A7E7AB0205F64D107DCAF888C36FBA19DAED60984AD82DAB67FFD01575280B41D7E09C32AA3244C357465D293771CBED28E3C59F0274DAF8A6D4CC6FBFAC251FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojMEANdStWW589N2lPmkazfw== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D1FF31E6DBADB52E051AC3E7EDD32E0A03841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v4 06/16] replication: send latest effective promote in initial join X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org> List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe> List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/> List-Post: <mailto:tarantool-patches@dev.tarantool.org> List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help> List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe> From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org> Reply-To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" <tarantool-patches-bounces@dev.tarantool.org> On 23.07.2021 09:44, Sergey Petrenko wrote: > > 22.07.2021 01:24, Vladislav Shpilevoy пишет: >> Hi! Good job on the patch! >> >>> diff --git a/src/box/relay.cc b/src/box/relay.cc >>> index 4ebe0fb06..4b102a777 100644 >>> --- a/src/box/relay.cc >>> +++ b/src/box/relay.cc >>> @@ -442,7 +445,11 @@ relay_initial_join(int fd, uint64_t sync, struct vclock *vclock, >>> row.type = IPROTO_JOIN_META; >>> coio_write_xrow(&relay->io, &row); >>> - /* Empty at the moment. */ >>> + char body[XROW_SYNCHRO_BODY_LEN_MAX]; >>> + xrow_encode_synchro(&row, body, &req); >>> + row.replica_id = req.replica_id; >>> + row.sync = sync; >> Shouldn't we also attach sync to IPROTO_JOIN_SNAPSHOT and >> IPROTO_JOIN_META? Although I don't see where it is used in >> the applier. But I see it is attached to xrow_encode_vclock >> a bit above. > > Yes, indeed. Will it be enough to set sync once only when sending the vclock? I don't even know why is it needed for vclock, tbh. Applier does not keep track of these syncs anyway. I suppose we can leave it just for vclock for now.