From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 841BE2BF95 for ; Wed, 24 Apr 2019 08:02:35 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rZoxuLk6Miow for ; Wed, 24 Apr 2019 08:02:35 -0400 (EDT) Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 4460E2BF1F for ; Wed, 24 Apr 2019 08:02:35 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v2 1/1] tap: fix is_deeply box.NULL corner cases References: <140e8187-8f84-c89d-10d8-57891e8f9353@tarantool.org> <20190424115713.dg5oqqyarg4fvich@tkn_work_nb> From: Vladislav Shpilevoy Message-ID: <0e66ac3b-9c9d-6097-fd95-c6ec9ae43273@tarantool.org> Date: Wed, 24 Apr 2019 15:02:32 +0300 MIME-Version: 1.0 In-Reply-To: <20190424115713.dg5oqqyarg4fvich@tkn_work_nb> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Alexander Turenko , tarantool-patches@freelists.org, Kirill Shcherbatov On 24/04/2019 14:57, Alexander Turenko wrote: >> @@ -163,6 +173,7 @@ local function is_deeply(test, got, expected, message, extra) >> extra = extra or {} >> extra.got = got >> extra.expected = expected >> + extra.strict = test.strict > > The 'extra' parameter is needed to provide a user more information in > case of a fail. Here we use it to push options for cmpdeeply(). I would > add 'opts' parameter instead. > If you do not like extra output about 'strict' value, then we could make it 'nil' by default, not 'false', and it will not be printed until someone starts to use it.