From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6D08D6F185C; Wed, 29 Nov 2023 17:48:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6D08D6F185C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1701269286; bh=bXdiKYf2YWMPs2kIOPQuKJqTvnrDmjqRyqQMKffLF+0=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=bDlX1ncHW7qmztGdIUdY7j6TCr1gDWrz6hOiY4YMZXea08/Fui9VkZaY03wTyYW8Y ZCH+nh8XB8Dzg58xeiD6iCttdXsWalLCNV8UsjVyUJcj1/wnOuQdOTrBe5I8BP/tXr H2WNW75+8wfFBBqfza/FeB4gq7Hj2g4L+KTmC0do= Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [95.163.41.91]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5472F6F1841 for ; Wed, 29 Nov 2023 17:48:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5472F6F1841 Received: by smtp49.i.mail.ru with esmtpa (envelope-from ) id 1r8LrA-00EbYe-14; Wed, 29 Nov 2023 17:48:04 +0300 Message-ID: <0e52ed21-4c1a-4fa0-9d57-0dd1bcacdf6c@tarantool.org> Date: Wed, 29 Nov 2023 17:48:04 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <78ee203fe7832fde6d2f1dfb40591b8f191e59a5.1698049570.git.skaplun@tarantool.org> In-Reply-To: <78ee203fe7832fde6d2f1dfb40591b8f191e59a5.1698049570.git.skaplun@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9D2A6479154BC7F417F3587B7BFEB0898590F1491F5F80929182A05F5380850405ECD22DF27FA7470D057CC7C69D3CEE559B5C927F5EFACAB7F7E7E14C30A609A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A3DED2DACB82E709C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7965AF5021CACFC748F08D7030A58E5AD1A62830130A00468AEEEE3FBA3A834EE7353EFBB55337566B720CBEDDCA346D4FC1F8A07E406B23803369598F9042F0CA471835C12D1D9774AD6D5ED66289B5278DA827A17800CE70F3DDF2BBF19B93A9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3CF36E64A7E3F8E58117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF4B59EA02F05B58D7BA3038C0950A5D36C8A9BA7A39EFB766D91E3A1F190DE8FDBA3038C0950A5D36D5E8D9A59859A8B6AF6A8D56EAD0601C76E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C224936DA1BED736F9328E827F84554CEF50127C277FBC8AE2E8BF1175FABE1C0F9B6AAAE862A0553A39223F8577A6DFFEA7CEB50775E5DF83D4A43847C11F186F3C59DAA53EE0834AAEE X-C1DE0DAB: 0D63561A33F958A59CB86F835E1381C1B5DB8EF1388742BAC6EC20BF4CFA3F44F87CCE6106E1FC07E67D4AC08A07B9B01E44367C8E80A7B4CB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D341ADA1A41A420E9B22C777F22DD030EF8D9826443E3C9AB33407BFE74E72600743996C689EA6DDE5A1D7E09C32AA3244C64822FEA5AD01EFFFB66E7B2E69539247101BF96129E401185A42E4C463514DC5DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojxXIty/pLbaj7CQqvCKw73w== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769CAE855FC6299D29ED057CC7C69D3CEE5816609AA8FC7A761EBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/6] FFI: Ensure returned string is alive in ffi.typeinfo(). X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hello, Sergey thanks for the patch! LGTM On 10/23/23 12:22, Sergey Kaplun wrote: > From: Mike Pall > > Reported by zhuizhuhaomeng. > > (cherry-picked from commit 94a40bb238092e73f3dc0c3626911a7efa997c22) > > `ffi.typeinfo()` doesn't check that the string containing the name type > is alive when it sets this string to the returned table. This leads to > the corresponding assertion failure in `checklivetv()`. This patch flips > the white colour of the stored string to resurrect it. > > Sergey Kaplun: > * added the description and the test for the problem > > Part of tarantool/tarantool#9145