From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 32ECC45C304
 for <tarantool-patches@dev.tarantool.org>;
 Sun, 20 Dec 2020 20:01:04 +0300 (MSK)
References: <20201214113935.1040421-1-gorcunov@gmail.com>
 <20201214113935.1040421-4-gorcunov@gmail.com>
 <2b00fba4-63bd-559f-c273-a02cf3fed6f3@tarantool.org>
 <20201218081416.GG14556@grain>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <0df4021b-b2b5-0157-e532-0845b0842e92@tarantool.org>
Date: Sun, 20 Dec 2020 18:01:02 +0100
MIME-Version: 1.0
In-Reply-To: <20201218081416.GG14556@grain>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v4 3/3] test: add
 replication/gh-5446-qsync-eval-quorum.test.lua
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Mons Anderson <v.perepelitsa@corp.mail.ru>, tml <tarantool-patches@dev.tarantool.org>

Thanks for the fixes!

> Took both notes from some existing example. Would the following be better?

Yes, thanks, it does not raise any questions now. Although
you could keep 's' variable to access the space methods shorter.

> ---
> diff --git a/test/replication/gh-5446-qsync-eval-quorum.test.lua b/test/replication/gh-5446-qsync-eval-quorum.test.lua
> index 2ecfa8c3e..9f731a488 100644
> --- a/test/replication/gh-5446-qsync-eval-quorum.test.lua
> +++ b/test/replication/gh-5446-qsync-eval-quorum.test.lua
> @@ -17,10 +17,8 @@ test_run:grep_log("default", match) ~= nil
>  
>  -- Create a sync space we will operate on
>  _ = box.schema.space.create('sync', {is_sync = true, engine = engine})
> -s = box.space.sync
> -s:format({{name = 'id', type = 'unsigned'}, {name = 'value', type = 'unsigned'}})
> -_ = s:create_index('primary', {parts = {'id'}})
> -s:insert{1, 1}
> +_ = box.space.sync:create_index('pk')
> +box.space.sync:insert{1}