From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvasiliev@tarantool.org>
Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7E705445320
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 22 Jul 2020 18:28:56 +0300 (MSK)
References: <cover.1595371239.git.v.shpilevoy@tarantool.org>
 <9193c791b19ac495f831aba37a906bf87742a87d.1595371239.git.v.shpilevoy@tarantool.org>
From: Leonid Vasiliev <lvasiliev@tarantool.org>
Message-ID: <0dc7ceb0-c88e-977c-5396-404f93503721@tarantool.org>
Date: Wed, 22 Jul 2020 18:28:55 +0300
MIME-Version: 1.0
In-Reply-To: <9193c791b19ac495f831aba37a906bf87742a87d.1595371239.git.v.shpilevoy@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 2/2] txn: remove TXN_IS_DONE check
 from txn_commit()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org, gorcunov@gmail.com

Hi! Thank you for the patch.
LGTM.


> diff --git a/test/unit/suite.ini b/test/unit/suite.ini
> index d429c95e9..d16ba413b 100644
> --- a/test/unit/suite.ini
> +++ b/test/unit/suite.ini
> @@ -1,5 +1,6 @@
>   [default]
>   core = unittest
>   description = unit tests
> +disabled = snap_quorum_delay.test

Discussed the test with Vlad. I will write my point of view in
https://github.com/tarantool/tarantool/issues/5193

>   release_disabled = fiber_stack.test swim_errinj.test
>   is_parallel = True
>