From: Mergen Imeev via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: kyukhin@tarantool.org Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v4 15/16] sql: remove MEM_TYPE_AGG Date: Tue, 26 Oct 2021 13:34:30 +0300 [thread overview] Message-ID: <0db17fbc9dc167d757807dd5175dbf114923f618.1635244212.git.imeevma@gmail.com> (raw) In-Reply-To: <cover.1635244212.git.imeevma@gmail.com> This patch removed MEM_TYPE_AGG, which is no longer used due to recent changes. Part of #4145 --- src/box/sql/mem.c | 25 ------------------------- src/box/sql/mem.h | 11 ++--------- 2 files changed, 2 insertions(+), 34 deletions(-) diff --git a/src/box/sql/mem.c b/src/box/sql/mem.c index 917ff458c..dc629aee3 100644 --- a/src/box/sql/mem.c +++ b/src/box/sql/mem.c @@ -592,22 +592,6 @@ mem_set_frame(struct Mem *mem, struct VdbeFrame *frame) mem->u.pFrame = frame; } -int -mem_set_agg(struct Mem *mem, struct func *func, int size) -{ - mem_clear(mem); - if (size <= 0) - return 0; - if (sqlVdbeMemGrow(mem, size, 0) != 0) - return -1; - memset(mem->z, 0, size); - mem->n = size; - mem->type = MEM_TYPE_AGG; - assert(mem->flags == 0); - mem->u.func = func; - return 0; -} - void mem_set_null_clear(struct Mem *mem) { @@ -1863,15 +1847,6 @@ mem_len(const struct Mem *mem, uint32_t *len) return 0; } -int -mem_get_agg(const struct Mem *mem, void **accum) -{ - if (mem->type != MEM_TYPE_AGG) - return -1; - *accum = mem->z; - return 0; -} - int mem_copy(struct Mem *to, const struct Mem *from) { diff --git a/src/box/sql/mem.h b/src/box/sql/mem.h index 52a63949a..242f910db 100644 --- a/src/box/sql/mem.h +++ b/src/box/sql/mem.h @@ -54,7 +54,6 @@ enum mem_type { MEM_TYPE_INVALID = 1 << 11, MEM_TYPE_FRAME = 1 << 12, MEM_TYPE_PTR = 1 << 13, - MEM_TYPE_AGG = 1 << 14, }; /* @@ -185,12 +184,6 @@ mem_is_array(const struct Mem *mem) return mem->type == MEM_TYPE_ARRAY; } -static inline bool -mem_is_agg(const struct Mem *mem) -{ - return mem->type == MEM_TYPE_AGG; -} - static inline bool mem_is_bytes(const struct Mem *mem) { @@ -242,7 +235,7 @@ static inline bool mem_is_trivial(const struct Mem *mem) { return mem->szMalloc == 0 && (mem->flags & MEM_Dyn) == 0 && - (mem->type & (MEM_TYPE_FRAME | MEM_TYPE_AGG)) == 0; + mem->type != MEM_TYPE_FRAME; } static inline bool @@ -955,7 +948,7 @@ int sqlVdbeMemTooBig(Mem *); * that needs to be deallocated to avoid a leak. */ #define VdbeMemDynamic(X) (((X)->flags & MEM_Dyn) != 0 ||\ - ((X)->type & (MEM_TYPE_AGG | MEM_TYPE_FRAME)) != 0) + ((X)->type & MEM_TYPE_FRAME) != 0) /** * Perform comparison of two tuples: unpacked (key1) and packed (key2) -- 2.25.1
next prev parent reply other threads:[~2021-10-26 10:41 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-10-26 10:34 [Tarantool-patches] [PATCH v4 00/16] sql: refactor aggregate functions Mergen Imeev via Tarantool-patches 2021-10-26 10:34 ` [Tarantool-patches] [PATCH v4 01/16] sql: remove MEM_Zero flag from struct MEM Mergen Imeev via Tarantool-patches 2021-10-26 10:34 ` [Tarantool-patches] [PATCH v4 02/16] sql: fix possible undefined behavior during cast Mergen Imeev via Tarantool-patches 2021-10-26 10:34 ` [Tarantool-patches] [PATCH v4 03/16] sql: use register P1 for number of arguments Mergen Imeev via Tarantool-patches 2021-10-26 10:34 ` [Tarantool-patches] [PATCH v4 04/16] sql: remove AggStep0 and OP_BuiltinFunction0 Mergen Imeev via Tarantool-patches 2021-10-26 10:34 ` [Tarantool-patches] [PATCH v4 05/16] sql: move collation to struct sql_context Mergen Imeev via Tarantool-patches 2021-10-26 10:34 ` [Tarantool-patches] [PATCH v4 06/16] sql: introduce mem_append() Mergen Imeev via Tarantool-patches 2021-10-26 10:34 ` [Tarantool-patches] [PATCH v4 07/16] sql: remove sql_vdbemem_finalize() Mergen Imeev via Tarantool-patches 2021-10-26 10:34 ` [Tarantool-patches] [PATCH v4 08/16] sql: refactor SUM() function Mergen Imeev via Tarantool-patches 2021-10-26 10:34 ` [Tarantool-patches] [PATCH v4 09/16] sql: refactor TOTAL() function Mergen Imeev via Tarantool-patches 2021-10-26 10:34 ` [Tarantool-patches] [PATCH v4 10/16] sql: refactor AVG() function Mergen Imeev via Tarantool-patches 2021-10-26 10:34 ` [Tarantool-patches] [PATCH v4 11/16] sql: refactor COUNT() function Mergen Imeev via Tarantool-patches 2021-10-26 10:34 ` [Tarantool-patches] [PATCH v4 12/16] sql: refactor MIN() and MAX() functions Mergen Imeev via Tarantool-patches 2021-10-26 10:34 ` [Tarantool-patches] [PATCH v4 13/16] sql: refactor GROUP_CONCAT() function Mergen Imeev via Tarantool-patches 2021-10-26 10:34 ` [Tarantool-patches] [PATCH v4 14/16] sql: remove copying of result in finalizers Mergen Imeev via Tarantool-patches 2021-10-26 10:34 ` Mergen Imeev via Tarantool-patches [this message] 2021-10-26 10:34 ` [Tarantool-patches] [PATCH v4 16/16] sql: remove field argv from struct sql_context Mergen Imeev via Tarantool-patches 2021-11-02 10:36 ` [Tarantool-patches] [PATCH v4 00/16] sql: refactor aggregate functions Kirill Yukhin via Tarantool-patches -- strict thread matches above, loose matches on Subject: below -- 2021-10-01 12:48 Mergen Imeev via Tarantool-patches 2021-10-01 12:48 ` [Tarantool-patches] [PATCH v4 15/16] sql: remove MEM_TYPE_AGG Mergen Imeev via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0db17fbc9dc167d757807dd5175dbf114923f618.1635244212.git.imeevma@gmail.com \ --to=tarantool-patches@dev.tarantool.org \ --cc=imeevma@tarantool.org \ --cc=kyukhin@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v4 15/16] sql: remove MEM_TYPE_AGG' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox