From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id BF29530C8C
	for <tarantool-patches@freelists.org>; Fri,  7 Jun 2019 07:57:12 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id sa-2bL0YUE7c for <tarantool-patches@freelists.org>;
	Fri,  7 Jun 2019 07:57:12 -0400 (EDT)
Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 234EC30C7F
	for <tarantool-patches@freelists.org>; Fri,  7 Jun 2019 07:57:12 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v2 0/9] sql: cleanup code from
 obsolete macros
References: <cover.1559138377.git.szudin@tarantool.org>
 <08530D5F-C413-4E0E-8251-DC61DFD24BED@tarantool.org>
From: Stanislav Zudin <szudin@tarantool.org>
Message-ID: <0d83bb70-a1cb-061e-7d7a-1090a5cee6d2@tarantool.org>
Date: Fri, 7 Jun 2019 14:57:08 +0300
MIME-Version: 1.0
In-Reply-To: <08530D5F-C413-4E0E-8251-DC61DFD24BED@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, "n.pettik" <korablev@tarantool.org>



On 06.06.2019 21:22, n.pettik wrote:
> 
> 
>> On 29 May 2019, at 17:01, Stanislav Zudin <szudin@tarantool.org> wrote:
>>
>> The patch removes unused constants and macros
>> The 2nd version returns back the SQL_OMIT_AUTOMATIC_INDEX and
>> the code enabled by this macro.
>> Removes the remains of the multithreading from the VDBE's
>> sorting tools.
>> Enables output of number of scanned rows when EXPLAIN
>> keyword is used. Updates the affected tests.
> 
> Generally speaking, patch-set is OK since it provides
> straightforward refactoring. But I would whether squash
> all these patches or change their description and group
> by thematic topics (like sql: remove unused macros
> connected with memory management system).
> It’s up to you.
> 
> 

I've squashed commits and rebased.