From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 35109469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  3 Jun 2020 10:02:13 +0300 (MSK)
From: Oleg Babin <olegrok@tarantool.org>
References: <20200602221817.645015-1-gorcunov@gmail.com>
 <20200602221817.645015-10-gorcunov@gmail.com>
Message-ID: <0d5be94f-1418-782d-e319-8b587dcc8252@tarantool.org>
Date: Wed, 3 Jun 2020 10:02:11 +0300
MIME-Version: 1.0
In-Reply-To: <20200602221817.645015-10-gorcunov@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v8 09/12] test: logger -- use log
	module directly
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>, tml <tarantool-patches@dev.tarantool.org>

Hi! Thanks for your patch see one comment below.

On 03/06/2020 01:18, Cyrill Gorcunov wrote:

> +-- Test that changes in log module are propagated
> +-- back to the box module correctly
> +box.cfg{
> +    log=filename,
> +    log_format='json',
> +    log_level=6,
> +    memtx_memory=107374182,
> +}
> +test:is(box.cfg.log_format, 'json', 'box in json format')
> +test:is(box.cfg.log_level, 6, 'box level 6')

It's quite strange. You change box.cfg options and check that box.cfg 
options are changed. I suppose you should check log.cfg options here.

Anyway if you cover that box.cfg change propagates to log.cfg you should 
test that log.cfg changes propagate to box.cfg as well.