From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 4BE89D27797; Thu, 4 Jul 2024 18:00:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4BE89D27797 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1720105206; bh=lVhj0sQ3Dani2kaCTc2upnE5ycGwqXynytS+otEY0NM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=tkTksDeTDeZ/oOWDDQgX1bDZJaHxiMY5MT2EpJUguzSZr4oDkLroWV/XXccV4/v8S axsIIT/AAzfuX5XDd1l1p9OjsvVB9XRvpXSLnC33oBlDIAgkph4T445bTkW7Qa9yYS 1xs3Hs7QigLnOrAZ3OBB6LCUvcnsLap6irYBnNWw= Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [95.163.41.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BEA36D27797 for ; Thu, 4 Jul 2024 17:59:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BEA36D27797 Received: by exim-smtp-7c4d4874bc-969kv with esmtpa (envelope-from ) id 1sPNwA-000000001Vi-0NAY; Thu, 04 Jul 2024 17:59:54 +0300 Content-Type: multipart/alternative; boundary="------------enHA03he0PaF1kITOHkhaoPh" Message-ID: <0d3fba19-7328-4f1b-a253-7fce32fa2fe6@tarantool.org> Date: Thu, 4 Jul 2024 17:59:53 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: <78410e4aed436f123711eeb89d4a4146949b4eef.1719329795.git.skaplun@tarantool.org> <13a5ffa5-c7b4-4476-8969-5dd5c9fadf50@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD98779A897EF6512F7771459BC08D6E5AAF85F1BFCF94BE053182A05F5380850403B8B1AF71E7E71CD3DE06ABAFEAF670577B71E7C6739C2C93B62E1A1FFA979E0985936BB30EC2273 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AA1605287C7F04D6EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063702DFA59B3C994360EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B043BF0FB74779F36F4635F11F1B364C5B28ECE9528757049CDC06555150F6782A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE7A3E989B1926288338941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B61638054B7D09EC08CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C224964AF6B2A5E195AA176E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8B93AA53B0B255C7C23AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735BFC944FC657CDB72C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5386697531CDEB6335002B1117B3ED696DA3ADE34BB60C06DCCE9A60C8CB01D7C823CB91A9FED034534781492E4B8EEAD09F854029C6BD0DABDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34F0A5F58274334C95F4E24EC862B67A5B3CE0517E7CE95323DFCCFE4A75523A001E868405455EC7A61D7E09C32AA3244C1CD57DE802E1A51D77DD89D51EBB7742853AE8FBA99F36E3EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojxv0jG2S+cqepB0BWrJm8tg== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D6140C234C65D5D65F2049487ABAC94A94B54A984520E0D55462F0152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/2] Prevent sanitizer warning in snap_restoredata(). X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------enHA03he0PaF1kITOHkhaoPh Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks! LGTM On 04.07.2024 11:41, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Added the corresponding line, as you suggested. Branch is force pushed. > > On 04.07.24, Sergey Bronnikov wrote: >> Hi, Sergey, >> >> thanks for the patch! >> >> Please add a message "Also, it removes all related UBSAN suppressions, >> since they are fixed." >> >> to commit message, like you did for the second patch. >> >> >> LGTM >> > > --------------enHA03he0PaF1kITOHkhaoPh Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,


thanks! LGTM

On 04.07.2024 11:41, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!
Added the corresponding line, as you suggested. Branch is force pushed.

On 04.07.24, Sergey Bronnikov wrote:

Hi, Sergey,

thanks for the patch!

Please add a message "Also, it removes all related UBSAN suppressions, 
since they are fixed."

to commit message, like you did for the second patch.


LGTM


<snipped>
--------------enHA03he0PaF1kITOHkhaoPh--