From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A90512A882 for ; Tue, 11 Sep 2018 06:22:51 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id y9PYNLxHmaOP for ; Tue, 11 Sep 2018 06:22:51 -0400 (EDT) Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 695742A82F for ; Tue, 11 Sep 2018 06:22:51 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 2/2] sql: remove GLOB from Tarantool References: <4607dc428909e96915e9f0984a7733a0890a3185.1534436836.git.n.tatunov@tarantool.org> <76466086-2a5f-8f12-cbc3-4ddf26e30fd9@tarantool.org> <32D1E5EA-EA21-4E4B-B5F5-80B6578BFBED@tarantool.org> <20180911101152.jjfo6zakd37thoxf@tkn_work_nb> From: Alex Khatskevich Message-ID: <0d1f3c7a-add7-df0e-7997-720009434624@tarantool.org> Date: Tue, 11 Sep 2018 13:22:45 +0300 MIME-Version: 1.0 In-Reply-To: <20180911101152.jjfo6zakd37thoxf@tkn_work_nb> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Alexander Turenko , Nikita Tatunov Cc: Nikita Pettik , tarantool-patches@freelists.org On 11.09.2018 13:11, Alexander Turenko wrote: > Hi! > > See below. > > WBR, Alexandr Turenko. > > On Tue, Sep 11, 2018 at 10:38:38AM +0300, Nikita Tatunov wrote: >> Hello, thank you for comments. >> See full diff is at the end of the letter. >> >>>>>> - "ESCAPE expression must be a single character", >>>>>> + "ESCAPE expression must be a" >>>>>> + " single character", >>>>> Do not split error messages at the middle of a sentence. It makes errors ungreppable. >>>>> Make it <80 somehow different. >>>>> >>>> Have already been discussed in this thread. >>> I suppose that we concluded to try to fit into 80 and split the string only >>> in case it is impossible. >> I don’t think so. Anyways, Alexander could you please give your thoughts? > Nikita P. gives key_def.c as the example where we don't create constant > variables in the case. We shouldn't here too I think. At least it should > not be enforced. Actually, Nikita gave it as an example of file where 80 symbols rule is not broken (it is not about using constants to avoid this). If you can provide any arguments on why we should broke the line, while it is possible to keep it as a whole by just creating constant variable in the same scope - I will accept it. Otherwise, arguments for keeping all error messages non-broken which I have mentioned are very important in my opinion and I insist that message is not broken.