From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 74C9D469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 17 Sep 2020 17:43:02 +0300 (MSK)
References: <20200911215115.6622-1-roman.habibov@tarantool.org>
 <20200911215115.6622-3-roman.habibov@tarantool.org>
 <20200916132708.GB10599@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <0d1cda9d-43d6-5f5b-01c7-e01c3579ac3f@tarantool.org>
Date: Thu, 17 Sep 2020 16:43:00 +0200
MIME-Version: 1.0
In-Reply-To: <20200916132708.GB10599@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v4 2/6] sql: refactor
 create_table_def and parse
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>, Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 16.09.2020 15:27, Nikita Pettik wrote:
> On 12 Sep 00:51, Roman Khabibov wrote:
>> Move ck, fk constraint lists and autoincrement info from
>> struct create_table_def to struct Parse to make the code more
>> reusable when implementing <ALTER TABLE ADD COLUMN>.
>>
>> Needed for #3075
>> ---
> 
> Does ANSI allow to include constraints in ADD COLUMN statement?

Yes.

> Why did you decide to add autoincrement to this list? Was there any
> discussion on this subj?

There is nothing to discuss. It is either a part of the standard or
not. Romain said it is (I didn't check though).