From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C64302A60E for ; Mon, 27 Aug 2018 21:43:19 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id GTZy8UBXxTSF for ; Mon, 27 Aug 2018 21:43:19 -0400 (EDT) Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 85DAA29D14 for ; Mon, 27 Aug 2018 21:43:19 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v2 0/2] sql: remove struct Enc References: From: Vladislav Shpilevoy Message-ID: <0d1b6aff-7d9b-0695-3c5d-4c1482cd0d9c@tarantool.org> Date: Mon, 27 Aug 2018 22:43:11 -0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Kirill Shcherbatov Hi! Thanks for the patchset! Next time, please, answer on my review remarks in a separate reply letter in the old thread if you send a new version in a new thread. On 27/08/2018 08:11, Kirill Shcherbatov wrote: > Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3545-remove-enc-struct > Issue: https://github.com/tarantool/tarantool/issues/3545 > > We shouldn't use legacy Enc structure in SQL as we have > featured class mpstream in tarantool core. With this path > all allocations temporally commited with mpstream initialized Typo: 'commited' -> 'committed'. > on region and then duplicated in dynamic persistent memory via > sqlite3DbMallocRaw. > As a first step, we've moved mpstream API in core lib and reworked > all legacy interfaces. > > Changes in v2: > - rebased to master, merged with new func > sql_index_update_table_name. > - reworked legacy code with new mpstream library API > > Kirill Shcherbatov (2): > box: export mpstream methods to core > sql: remove struct Enc > > src/CMakeLists.txt | 1 + > src/box/lua/call.c | 11 +- > src/box/lua/misc.cc | 1 + > src/box/lua/net_box.c | 127 ++++++------ > src/box/lua/tuple.c | 23 +-- > src/box/sql.c | 473 +++++++++++++++++++++++---------------------- > src/box/sql/build.c | 156 ++++++++------- > src/box/sql/tarantoolInt.h | 80 +++++--- > src/box/sql/trigger.c | 62 +++--- > src/lua/msgpack.c | 166 ++-------------- > src/lua/msgpack.h | 102 +--------- > src/mpstream.c | 205 ++++++++++++++++++++ > src/mpstream.h | 124 ++++++++++++ > 13 files changed, 845 insertions(+), 686 deletions(-) > create mode 100644 src/mpstream.c > create mode 100644 src/mpstream.h >