From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D4F222132E for ; Wed, 30 Jan 2019 08:57:05 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id e9HTWap8auV4 for ; Wed, 30 Jan 2019 08:57:05 -0500 (EST) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 7CF53211D6 for ; Wed, 30 Jan 2019 08:57:05 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH v5 1/6] sql: remove unused macros from pragma.c and pragma.h References: <1f667d56f6684a5cb7030097a66c4ac8b46d36cc.1548771900.git.imeevma@gmail.com> From: Vladislav Shpilevoy Message-ID: <0cd617a8-f3f3-7d17-4669-54ee54cc37a0@tarantool.org> Date: Wed, 30 Jan 2019 16:57:03 +0300 MIME-Version: 1.0 In-Reply-To: <1f667d56f6684a5cb7030097a66c4ac8b46d36cc.1548771900.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, imeevma@tarantool.org Cc: korablev@tarantool.org Hi! Thanks for the patch! On 29/01/2019 17:29, imeevma@tarantool.org wrote: > Some macros in pragma.c and pragma.h are obsolete because the > values they are checking are no longer used or their usage makes > no sense. Let's remove them. > --- > src/box/sql/CMakeLists.txt | 2 -- > src/box/sql/parse.y | 4 ++-- > src/box/sql/pragma.c | 4 ---- > src/box/sql/pragma.h | 31 ++----------------------------- > src/box/sql/select.c | 22 +++++++++++----------- > src/box/sql/sqliteInt.h | 18 +----------------- > src/box/sql/where.c | 46 ++++++++++++++++++++-------------------------- > src/box/sql/whereInt.h | 4 ++-- > 8 files changed, 38 insertions(+), 93 deletions(-) > > diff --git a/src/box/sql/CMakeLists.txt b/src/box/sql/CMakeLists.txt > index 7f7b60e..68e2929 100644 > --- a/src/box/sql/CMakeLists.txt > +++ b/src/box/sql/CMakeLists.txt > @@ -1,7 +1,5 @@ > if(CMAKE_BUILD_TYPE STREQUAL "Debug") > add_definitions(-DSQLITE_DEBUG=1) > - add_definitions(-DSQLITE_ENABLE_SELECTTRACE) Still is used in src/box/sql/printf.c. > - add_definitions(-DSQLITE_ENABLE_WHERETRACE) > endif() >