From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5A8114696C3
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 28 Mar 2020 02:37:06 +0300 (MSK)
References: <cover.1584608715.git.k.sosnin@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <0c7478a4-c62c-4bde-21b1-ebb6601b2def@tarantool.org>
Date: Sat, 28 Mar 2020 00:37:03 +0100
MIME-Version: 1.0
In-Reply-To: <cover.1584608715.git.k.sosnin@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 0/2] fix assertion fault in SELECT *
	FROM "_vfunc"
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Chris Sosnin <k.sosnin@tarantool.org>, korablev@tarantool.org, tarantool-patches@dev.tarantool.org

Hi! Thanks for the patchset!

LGTM.

On 19/03/2020 10:14, Chris Sosnin wrote:
> First patch allows performing schema upgrades within one release.
> 
> Second patch updates _vfunc format in 2.3.1.1 (the last number is not
> visible to users).
> 
> branch:https://github.com/tarantool/tarantool/tree/ksosnin/gh-4666-select-from-vfunc
> issue #1:https://github.com/tarantool/tarantool/issues/4804
> issue #2:https://github.com/tarantool/tarantool/issues/4666
> 
> Chris Sosnin (2):
>   box: allow schema upgrades within a release
>   sql: fix assertion fault in SELECT * FROM "_vfunc"
> 
>  src/box/bootstrap.snap                        | Bin 5976 -> 5970 bytes
>  src/box/lua/upgrade.lua                       |  17 ++++++++++++++---
>  test/box-py/bootstrap.result                  |  11 +++++++++--
>  test/sql/engine.cfg                           |   1 +
>  test/sql/gh-4666-sql-select-from-vfunc.result |   7 +++++++
>  .../gh-4666-sql-select-from-vfunc.test.lua    |   4 ++++
>  6 files changed, 35 insertions(+), 5 deletions(-)
>  create mode 100644 test/sql/gh-4666-sql-select-from-vfunc.result
>  create mode 100644 test/sql/gh-4666-sql-select-from-vfunc.test.lua
>