From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 77F492B562 for ; Wed, 24 Apr 2019 10:22:08 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JDFBTnhsGH1U for ; Wed, 24 Apr 2019 10:22:08 -0400 (EDT) Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1EF5C2B3AB for ; Wed, 24 Apr 2019 10:22:07 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: check access rights of table in VIEW References: <3f7dd91795bf6154382cce7732a1016fc24ebcdc.1556108155.git.kshcherbatov@tarantool.org> <94baf90f-acd5-04ae-0bcd-8f800e6518c4@tarantool.org> From: Vladislav Shpilevoy Message-ID: <0c356e1f-5bf7-a11e-8634-8bf099c06a03@tarantool.org> Date: Wed, 24 Apr 2019 17:22:04 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Kirill Shcherbatov , tarantool-patches@freelists.org, Kirill Yukhin LGTM. On 24/04/2019 17:02, Kirill Shcherbatov wrote: > On 24.04.2019 16:48, Vladislav Shpilevoy wrote: >> Thanks for the patch! >>> +test_run = require('test_run').new() >> >> 1. You do not use this object, so it can be omitted. > >> 2. You pass here box.cfg.listen directly, without splitting into >> parts. >> >> Please, consider my review fixes below and on the branch: > > Looks good for me, thanks. Amend. >