From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CB4AB158B394; Mon, 17 Nov 2025 16:59:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CB4AB158B394 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1763387988; bh=7BTEuTALAcJoyUi7l3OcQV/smhHldtZSqGdZsSVFu98=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=E0R6igD4OTuxGk6f9UZq0AWO/iAFXZeFII1Vp77LgimLPU6tSldemUX19uH+UH1dz pJI2S8q4KoqAv3dUUInTt7TzXKT1yy2QF52CloxeTIRZO4vY58C/LJrDxSaI/EHg/C M46Q/EnDM93dtfgnMarh3Ja4Md0PJy0Paa2LdlE4= Received: from send105.i.mail.ru (send105.i.mail.ru [89.221.237.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 33695158B3B7 for ; Mon, 17 Nov 2025 16:59:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 33695158B3B7 Received: by exim-smtp-88cf54d45-ts29n with esmtpa (envelope-from ) id 1vKzl2-00000000CVm-1Isc; Mon, 17 Nov 2025 16:59:04 +0300 Content-Type: multipart/alternative; boundary="------------ddGhppedyL0qlzchbvaitQNg" Message-ID: <0bee5954-c6f6-47e7-8ec4-50dd323792ba@tarantool.org> Date: Mon, 17 Nov 2025 16:59:04 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <6afff7d5f3be90f8c346ccbd42db20269cad8c1f.1761301736.git.skaplun@tarantool.org> In-Reply-To: <6afff7d5f3be90f8c346ccbd42db20269cad8c1f.1761301736.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9110BAFCBE6BD1D1638C0B25128CE808CCB9265028675342F182A05F538085040985876059A942E003DE06ABAFEAF67053BC83AA3E1AF4923D487FD47310B043B067A636123F0E402 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75C385DEB91CEC222EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F88016AB904663428638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2B30C28718C1968942E070BE324C7D3C439F8ABD662B6E570F6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249D082881546D93491CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0A3E989B1926288338941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD269176DF2183F8FC7C0CAB4775CB929E3BB7B076A6E789B0E97A8DF7F3B2552694AD5FFEEA1DED7F25D49FD398EE364050F9647ADFADE5905B1F41620B44FB51B7DB3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BC6A536F79815AD9275ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A51C570A3F3294C27F5002B1117B3ED69675AEAF7CBA58FB49C89B063BDC7FAC35823CB91A9FED034534781492E4B8EEADA91A6E18C88C5E2F X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFAE3D242951103E871ECF273267658B60C174FD5EBB8C2D1AA91CCFD5F935E3EE46C06E59B4E81405DD12B02666E4935658EC9A6E0CE87F985FBE7F2EAD842E4AEC7B988890259BDC111DC66A97D0BFE2913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVfFX+FmbwDW1ErZeZTrpalw= X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B59099374A50F22AFC73DE06ABAFEAF67053BC83AA3E1AF4923B7CBEF92542CD7C8795FA72BAB74744FC77752E0C033A69EA16A481184E8BB1C9B38E6EA4F046BE03A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 25/41] perf: adjust recursive-fib in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------ddGhppedyL0qlzchbvaitQNg Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for the patch! See my comments. Sergey On 10/24/25 13:50, Sergey Kaplun wrote: > This patch adjusts the aforementioned test to use the benchmark > framework introduced before. The default arguments are adjusted > according to the file. The arguments to the script still > can be provided in the command line run. > --- > perf/LuaJIT-benches/recursive-fib.lua | 28 +++++++++++++++++++++++++-- > 1 file changed, 26 insertions(+), 2 deletions(-) > > diff --git a/perf/LuaJIT-benches/recursive-fib.lua b/perf/LuaJIT-benches/recursive-fib.lua > index ef9950de..99af3f9e 100644 > --- a/perf/LuaJIT-benches/recursive-fib.lua > +++ b/perf/LuaJIT-benches/recursive-fib.lua > @@ -1,7 +1,31 @@ > +local bench = require("bench").new(arg) > + > local function fib(n) > if n < 2 then return 1 end > return fib(n-2) + fib(n-1) > end > > -local n = tonumber(arg[1]) or 10 > -io.write(string.format("Fib(%d): %d\n", n, fib(n))) debug print was lost, is it intentional? > +local n = tonumber(arg[1]) or 40 Why 40? > + > +local benchmark > +benchmark = { > + name = "recursive_fib", > + checker = function(res) > + local km1, k = 1, 1 > + for i = 2, n do > + local tmp = k + km1 > + km1 = k > + k = tmp > + end > + return k == res > + end, > + payload = function() > + local res = fib(n) > + -- Number of calls. > + benchmark.items = res * 2 - 1 > + return res > + end, > +} > + > +bench:add(benchmark) > +bench:run_and_report() --------------ddGhppedyL0qlzchbvaitQNg Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for the patch! See my comments.

Sergey

On 10/24/25 13:50, Sergey Kaplun wrote:
This patch adjusts the aforementioned test to use the benchmark
framework introduced before. The default arguments are adjusted
according to the <PARAM_x86.txt> file. The arguments to the script still
can be provided in the command line run.
---
 perf/LuaJIT-benches/recursive-fib.lua | 28 +++++++++++++++++++++++++--
 1 file changed, 26 insertions(+), 2 deletions(-)

diff --git a/perf/LuaJIT-benches/recursive-fib.lua b/perf/LuaJIT-benches/recursive-fib.lua
index ef9950de..99af3f9e 100644
--- a/perf/LuaJIT-benches/recursive-fib.lua
+++ b/perf/LuaJIT-benches/recursive-fib.lua
@@ -1,7 +1,31 @@
+local bench = require("bench").new(arg)
+
 local function fib(n)
   if n < 2 then return 1 end
   return fib(n-2) + fib(n-1)
 end
 
-local n = tonumber(arg[1]) or 10
-io.write(string.format("Fib(%d): %d\n", n, fib(n)))
debug print was lost, is it intentional? 
+local n = tonumber(arg[1]) or 40
Why 40? 
+
+local benchmark
+benchmark = {
+  name = "recursive_fib",
+  checker = function(res)
+    local km1, k = 1, 1
+    for i = 2, n do
+      local tmp = k + km1
+      km1 = k
+      k = tmp
+    end
+    return k == res
+  end,
+  payload = function()
+    local res = fib(n)
+    -- Number of calls.
+    benchmark.items = res * 2 - 1
+    return res
+  end,
+}
+
+bench:add(benchmark)
+bench:run_and_report()
--------------ddGhppedyL0qlzchbvaitQNg--