From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 10B201608602; Wed, 26 Nov 2025 14:58:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 10B201608602 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1764158307; bh=4UPMCHuO4N+GGJ3jGjeqUwuFT0KbXE6nHnIPBmfA5uw=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=X97ke/q4QdUwkhJqw6ueUnu6+RsAt3n6djF/YgGShigR3cGopFMeNV+ftFuAItlp3 ZNcmO7m0df8kG0VpEV7XHVjTeTW6FBqojlWjOYFDbjPqWRaAiET37DijxQmPYDqZCk TuM7DpDOYuKte7EFTxW0vAa5h5QjLGZQ+sgDaiKo= Received: from send126.i.mail.ru (send126.i.mail.ru [89.221.237.221]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A9022569060 for ; Wed, 26 Nov 2025 14:58:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A9022569060 Received: by exim-smtp-6c58c594f5-whnqg with esmtpa (envelope-from ) id 1vOEAC-0000000023F-2bAm; Wed, 26 Nov 2025 14:58:24 +0300 Content-Type: multipart/alternative; boundary="------------vF0LhUu3CY5SAxcHvesG5heT" Message-ID: <0b86c212-f997-4fc2-afa0-37cf948cb5ed@tarantool.org> Date: Wed, 26 Nov 2025 14:58:24 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <08ffbaee95a92ee9c166fa70b78e2d98c06928a2.1763991490.git.skaplun@tarantool.org> In-Reply-To: <08ffbaee95a92ee9c166fa70b78e2d98c06928a2.1763991490.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD966666887587E071ABEC11BCA88403C1A17330493FDE6C3D600894C459B0CD1B9147E296FC405B932F378A8CA21F699D6D7B91255BB5272CAD0406B887DC7A56FFF1B8FF185178A36 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F40AD8E56E74C9F0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB553375660CC9DC0D4886FBE812CF7AE4A965FE536C143EBE8F11FA64741089B70937959D389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A29E2F051442AF778941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6D52CD31C43BF465FCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249B899183D4666AAE776E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8B89C074F960B19C4B3AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735B17145F0B7815491C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5ABFA02F4DB719D4F5002B1117B3ED696E50F3151DD184ECE33EE06AFCD964888823CB91A9FED034534781492E4B8EEAD8D8BB953E4894305BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE191716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D65900268B45378A0DA92FC2EBDC09285C493D77571D4214859BA333CC36AA058DF33108B5E996A821A9B8341EE9D5BE9A0A0767DA12064C367BC0895EAAEFD6EC87A4C0FAD880B27E298CD93680B12512CF4C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVcWupAQoUeGvtEyOkD6NFEQ= X-Mailru-Sender: 811C44EDE0507D1FF7A5115BD94F8393CB4F55D62F039F041F93A76BF6F7B0A6B220BDD452E3E13C21DABEFA063E4A4C645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] macOS: Remove obsolete -single_module flag. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------vF0LhUu3CY5SAxcHvesG5heT Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for the patch! LGTM with two minor comments. Sergey On 11/24/25 23:26, Sergey Kaplun wrote: > From: Mike Pall > > Thanks to dundargoc. > > (cherry picked from commit 97813fb924edf822455f91a5fbbdfdb349e5984f) > > The aforementioned flag is the default since Xcode 2.2 [1]. You refer to the description in the previous commit, right? I would name a flag here instead > This patch removes this flag to avoid warnings for modern Xcode > versions at the linking stage. it is worth to mention our own modifications for CMake build system > > [1]:https://bugzilla.mozilla.org/show_bug.cgi?id=1743539#c1 > > Sergey Kaplun: > * added the description for the problem > > Part of tarantool/tarantool#11691 > --- > cmake/SetTargetFlags.cmake | 2 +- > src/Makefile.original | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/cmake/SetTargetFlags.cmake b/cmake/SetTargetFlags.cmake > index d6ee1693..a0f9d45a 100644 > --- a/cmake/SetTargetFlags.cmake > +++ b/cmake/SetTargetFlags.cmake > @@ -47,7 +47,7 @@ if(LUAJIT_ARCH STREQUAL "x86") > endif() > > if(CMAKE_SYSTEM_NAME STREQUAL "Darwin") > - AppendFlags(TARGET_SHARED_FLAGS -single_module -undefined dynamic_lookup) > + AppendFlags(TARGET_SHARED_FLAGS -undefined dynamic_lookup) > else() # Linux and FreeBSD. > AppendFlags(TARGET_BIN_FLAGS -Wl,-E) > list(APPEND TARGET_LIBS dl) > diff --git a/src/Makefile.original b/src/Makefile.original > index 8d925e3a..471d692c 100644 > --- a/src/Makefile.original > +++ b/src/Makefile.original > @@ -329,13 +329,13 @@ ifeq (Darwin,$(TARGET_SYS)) > endif > TARGET_STRIP+= -x > TARGET_XCFLAGS+= -DLUAJIT_UNWIND_EXTERNAL > - TARGET_XSHLDFLAGS= -dynamiclib -single_module -undefined dynamic_lookup -fPIC > + TARGET_XSHLDFLAGS= -dynamiclib -undefined dynamic_lookup -fPIC > TARGET_DYNXLDOPTS= > TARGET_XSHLDFLAGS+= -install_name $(TARGET_DYLIBPATH) -compatibility_version $(MAJVER).$(MINVER) -current_version $(MAJVER).$(MINVER).$(RELVER) > else > ifeq (iOS,$(TARGET_SYS)) > TARGET_STRIP+= -x > - TARGET_XSHLDFLAGS= -dynamiclib -single_module -undefined dynamic_lookup -fPIC > + TARGET_XSHLDFLAGS= -dynamiclib -undefined dynamic_lookup -fPIC > TARGET_DYNXLDOPTS= > TARGET_XSHLDFLAGS+= -install_name $(TARGET_DYLIBPATH) -compatibility_version $(MAJVER).$(MINVER) -current_version $(MAJVER).$(MINVER).$(RELVER) > ifeq (arm64,$(TARGET_LJARCH)) --------------vF0LhUu3CY5SAxcHvesG5heT Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for the patch! LGTM with two minor comments.

Sergey

On 11/24/25 23:26, Sergey Kaplun wrote:
From: Mike Pall <mike>

Thanks to dundargoc.

(cherry picked from commit 97813fb924edf822455f91a5fbbdfdb349e5984f)

The aforementioned flag is the default since Xcode 2.2 [1].

You refer to the description in the previous commit, right?

I would name a flag here instead

This patch removes this flag to avoid warnings for modern Xcode
versions at the linking stage.
it is worth to mention our own modifications for CMake build system 

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1743539#c1

Sergey Kaplun:
* added the description for the problem

Part of tarantool/tarantool#11691
---
 cmake/SetTargetFlags.cmake | 2 +-
 src/Makefile.original      | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/cmake/SetTargetFlags.cmake b/cmake/SetTargetFlags.cmake
index d6ee1693..a0f9d45a 100644
--- a/cmake/SetTargetFlags.cmake
+++ b/cmake/SetTargetFlags.cmake
@@ -47,7 +47,7 @@ if(LUAJIT_ARCH STREQUAL "x86")
 endif()
 
 if(CMAKE_SYSTEM_NAME STREQUAL "Darwin")
-  AppendFlags(TARGET_SHARED_FLAGS -single_module -undefined dynamic_lookup)
+  AppendFlags(TARGET_SHARED_FLAGS -undefined dynamic_lookup)
 else() # Linux and FreeBSD.
   AppendFlags(TARGET_BIN_FLAGS -Wl,-E)
   list(APPEND TARGET_LIBS dl)
diff --git a/src/Makefile.original b/src/Makefile.original
index 8d925e3a..471d692c 100644
--- a/src/Makefile.original
+++ b/src/Makefile.original
@@ -329,13 +329,13 @@ ifeq (Darwin,$(TARGET_SYS))
   endif
   TARGET_STRIP+= -x
   TARGET_XCFLAGS+= -DLUAJIT_UNWIND_EXTERNAL
-  TARGET_XSHLDFLAGS= -dynamiclib -single_module -undefined dynamic_lookup -fPIC
+  TARGET_XSHLDFLAGS= -dynamiclib -undefined dynamic_lookup -fPIC
   TARGET_DYNXLDOPTS=
   TARGET_XSHLDFLAGS+= -install_name $(TARGET_DYLIBPATH) -compatibility_version $(MAJVER).$(MINVER) -current_version $(MAJVER).$(MINVER).$(RELVER)
 else
 ifeq (iOS,$(TARGET_SYS))
   TARGET_STRIP+= -x
-  TARGET_XSHLDFLAGS= -dynamiclib -single_module -undefined dynamic_lookup -fPIC
+  TARGET_XSHLDFLAGS= -dynamiclib -undefined dynamic_lookup -fPIC
   TARGET_DYNXLDOPTS=
   TARGET_XSHLDFLAGS+= -install_name $(TARGET_DYLIBPATH) -compatibility_version $(MAJVER).$(MINVER) -current_version $(MAJVER).$(MINVER).$(RELVER)
   ifeq (arm64,$(TARGET_LJARCH))
--------------vF0LhUu3CY5SAxcHvesG5heT--