From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C87EF469719 for ; Fri, 11 Sep 2020 11:56:59 +0300 (MSK) From: "Alexander V. Tikhonov" Date: Fri, 11 Sep 2020 11:56:56 +0300 Message-Id: <0b53e2f0a0c7a35cfbbfef3a66a68a82147b46ad.1599814524.git.avtikhon@tarantool.org> Subject: [Tarantool-patches] [PATCH v1] test: flaky replication/gh-3704-misc-* List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kirill Yukhin , Serge Petrenko Cc: tarantool-patches@dev.tarantool.org On heavy loaded hosts found the following issue: [037] --- replication/gh-3704-misc-replica-checks-cluster-id.result Thu Sep 10 18:05:22 2020 [037] +++ replication/gh-3704-misc-replica-checks-cluster-id.reject Fri Sep 11 11:09:38 2020 [037] @@ -25,7 +25,7 @@ [037] ... [037] box.info.replication[2].downstream.status [037] --- [037] -- follow [037] +- stopped [037] ... [037] -- change master's cluster uuid and check that replica doesn't connect. [037] test_run:cmd("stop server replica") It happened because replication downstream status check occurred too early, when it was only in 'stopped' state. To give the replication status check routine ability to reach the needed 'follow' state, it need to wait for it using test_run:wait_downstream() routine. Closes #5293 --- Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5293-fix-3704 Issue: https://github.com/tarantool/tarantool/issues/5293 .../replication/gh-3704-misc-replica-checks-cluster-id.result | 4 ++-- .../gh-3704-misc-replica-checks-cluster-id.test.lua | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/test/replication/gh-3704-misc-replica-checks-cluster-id.result b/test/replication/gh-3704-misc-replica-checks-cluster-id.result index 1ca2913f8..27b4393ff 100644 --- a/test/replication/gh-3704-misc-replica-checks-cluster-id.result +++ b/test/replication/gh-3704-misc-replica-checks-cluster-id.result @@ -23,9 +23,9 @@ test_run:grep_log("replica", "REPLICASET_UUID_MISMATCH") --- - null ... -box.info.replication[2].downstream.status +test_run:wait_downstream(2, {status = 'follow'}) --- -- follow +- true ... -- change master's cluster uuid and check that replica doesn't connect. test_run:cmd("stop server replica") diff --git a/test/replication/gh-3704-misc-replica-checks-cluster-id.test.lua b/test/replication/gh-3704-misc-replica-checks-cluster-id.test.lua index 00c443a55..0d5378cae 100644 --- a/test/replication/gh-3704-misc-replica-checks-cluster-id.test.lua +++ b/test/replication/gh-3704-misc-replica-checks-cluster-id.test.lua @@ -9,7 +9,7 @@ test_run:cmd("create server replica with rpl_master=default, script='replication box.schema.user.grant("guest", "replication") test_run:cmd("start server replica") test_run:grep_log("replica", "REPLICASET_UUID_MISMATCH") -box.info.replication[2].downstream.status +test_run:wait_downstream(2, {status = 'follow'}) -- change master's cluster uuid and check that replica doesn't connect. test_run:cmd("stop server replica") _ = box.space._schema:replace{'cluster', tostring(uuid.new())} -- 2.17.1