From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1CF9E6FC8B; Sun, 25 Apr 2021 18:53:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1CF9E6FC8B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1619366000; bh=mDDHtP97hRZqRMAPzvYoO9zE37yLjFsWgG9ujEFx7vI=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=g2l6kf0c+jbA+kHO9snisM9huJ6zuAruR3FYtVUBsk7/sST14CqWVc24ieyHaBQrw Ilz84LQ1upuJEsMcqtc6+QNKt6YVKg5NI8g929k7o2Ap0quG4sdofrEKTeDlrjFO1D M0okKs9sEXhIT1uKAwNJyGBHaAU0oxsYzSq++p/g= Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0FCD36FC8B for ; Sun, 25 Apr 2021 18:53:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0FCD36FC8B Received: by smtpng2.m.smailru.net with esmtpa (envelope-from ) id 1lah4P-0003Md-DN; Sun, 25 Apr 2021 18:53:17 +0300 To: Serge Petrenko , tarantool-patches@dev.tarantool.org, gorcunov@gmail.com References: <8c48e98e0c9780e2fe4ffbf511ac95678561fcfe.1619219639.git.v.shpilevoy@tarantool.org> <2e89c2b4-fd13-2ca1-9c05-f8e95d2e92e6@tarantool.org> Message-ID: <0aed8e87-324f-01d0-c5d4-40a06d8006e7@tarantool.org> Date: Sun, 25 Apr 2021 17:53:16 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <2e89c2b4-fd13-2ca1-9c05-f8e95d2e92e6@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9203E2ABA940B7548CA3406377FA04A72641288DF385C0094182A05F5380850401023F77458CAD1CB1D8DCDA6498CF10221CC7D2C2DC2B4FA056307054D4AFE1B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FBB2043146276655EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F97367C191A19EB28638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2C93EB473AC236FE0DEDB2A7197CAA747CCD65611471A2689D2E47CDBA5A96583C09775C1D3CA48CFE478A468B35FE767117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE7ABB305BD10C6E5099FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA71A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89FB26E97DCB74E625235872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A58127379B4ACF4B24AA734C00FD05232AA6A3965E9DC1B388D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34128DEC38EFF4BE5AB3EF27622D7F9B0DC59B38A823BAB28B9A642B9506A771F7A50A36ADB1849AC01D7E09C32AA3244C559DF5CDF1D126F9F66B3903AF23155C69B6CAE0477E908DFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj08M52wfuxcFSBzmd2GxIAg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822DFBCA85DD75FD90B925AF9DE224667B03841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 1/2] fiber: make wakeup in Lua and C nop on self X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the review! >> + >> +local function test_wakeup_self_and_wal_write(test) >> +    test:plan(1) >> + >> +    local s = box.schema.create_space('test') >> +    s:create_index('pk') >> + >> +    fiber.wakeup(fiber.self()) >> +    local lsn = box.info.lsn >> +    s:replace{1} >> +    test:is(box.info.lsn, lsn + 1, 'written to WAL') >> +    s:drop() >> +end > > Again, shouldn't everything related to space creation, WAL writes and so on > reside in box-tap ? I may be wrong, just asking. It should, but this test is about testing the fibers, not the box. Box and the WAL write here are secondary things. The same as for app/fiber.test.lua (not TAP).